[Metrics UI] Enhance Inventory View Tooltips#69757
Merged
simianhacker merged 7 commits intoelastic:masterfrom Jul 1, 2020
Merged
[Metrics UI] Enhance Inventory View Tooltips#69757simianhacker merged 7 commits intoelastic:masterfrom
simianhacker merged 7 commits intoelastic:masterfrom
Conversation
simianhacker
added
Feature:Metrics UI
simianhacker
force-pushed
the
issue-65915-improve-waffle-map-tooltips
branch
7 times, most recently
from
81ab9ca to
6639919
Compare
simianhacker
force-pushed
the
issue-65915-improve-waffle-map-tooltips
branch
from
6639919 to
6eb4e6b
Compare
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Member
Author
|
@elasticmachine merge upstream |
Zacqary
approved these changes
Jun 30, 2020
Contributor
Zacqary
left a comment
Zacqary
left a comment
There was a problem hiding this comment.
Looks good to merge, just a couple typos to fix
| currentTime, | ||
| '', | ||
| '', | ||
| false // Doesn't sent request until reload() reload is called |
Contributor
There was a problem hiding this comment.
Nit: send request, wrote reload twice
| >(callClusterFactory(client), query, bucketSelector, handleAfterKey); | ||
| }; | ||
|
|
||
| const calcualteIndexPatterBasedOnMetrics = (options: InfraSnapshotRequestOptions) => { |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jul 1, 2020
* [Metrics UI] Enhance Inventory View Tooltips * Fixing typos * Removing toMetricOpt Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker
added a commit
that referenced
this pull request
Jul 2, 2020
* [Metrics UI] Enhance Inventory View Tooltips * Fixing typos * Removing toMetricOpt Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the inventory view tooltips by adding additional metrics when the tooltip is loaded. The data is loaded 250ms after the mouse has been hovering over the node. If the mouse leaves the node the request is canceled.
Checklist
Delete any items that are not applicable to this PR.