[Logs UI] Avoid CCS-incompatible index name resolution#70179
Merged
weltenwort merged 1 commit intoelastic:masterfrom Jul 1, 2020
Merged
[Logs UI] Avoid CCS-incompatible index name resolution#70179weltenwort merged 1 commit intoelastic:masterfrom
weltenwort merged 1 commit intoelastic:masterfrom
Conversation
weltenwort
added
release_note:fix
v8.0.0
Feature:Logs UI
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Kerry350
approved these changes
Jul 1, 2020
Contributor
Kerry350
left a comment
Kerry350
left a comment
There was a problem hiding this comment.
LGTM, works as expected against the CCS enabled cluster 👌
This was referenced Jul 1, 2020
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Jul 1, 2020
This fixes elastic#70048 by avoiding a CCS-incompatible ES API call when determining the existence of log indices. # Conflicts: # x-pack/plugins/infra/public/containers/logs/log_source/log_source.ts
weltenwort
added a commit
that referenced
this pull request
Jul 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
…-based-rbac * upstream/master: (38 commits) Move logger configuration integration test to jest (elastic#70378) Changes observability plugin codeowner (elastic#70439) update (elastic#70424) [Logs UI] Avoid CCS-incompatible index name resolution (elastic#70179) Enable "Explore underlying data" actions for Lens visualizations (elastic#70047) Initial work on uptime homepage API (elastic#70135) expressions indexPattern function (elastic#70315) [Discover] Deangularization context error message refactoring (elastic#70090) [Lens] Add "no data" popover (elastic#69147) [Lens] Move chart switcher over (elastic#70182) chore: add missing mjs extension (elastic#70326) [Lens] Multiple y axes (elastic#69911) skip flaky suite (elastic#70386) fix bug to add timeline to case (elastic#70343) [QA][Code Coverage] Drop catchError and use try / catch instead, (elastic#69198) [QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (elastic#69348) [Metrics UI] Add context.reason and alertOnNoData to Inventory alerts (elastic#70260) Resolver refactoring (elastic#70312) [Ingest Manager] Fix agent ack after input format change (elastic#70335) [eslint][ts] Enable prefer-ts-expect-error (elastic#70022) ...
weltenwort
added a commit
that referenced
this pull request
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #70048 by avoiding a CCS-incompatible ES API call when determining the existence of log indices.
Background
In 7.8.0 we switched the call that the Logs UI used to determine the presence of log indices to an
indices.getcall, which doesn't work with cross-cluster search. This switches the check back to asize:0search, because the index name list produced by theindices.getcall wasn't yet used anyway.Testing
As described in #70048, testing requires a setup of two clusters with one being configured as a remote cluster to the other. The Logs UI should then be able to display logs present on the remote cluster if the log indices are configured to only contain a reference to the remote indices.