[code coverage] ingest correct coveredFilePath for mocha#70215
Merged
dmlemeshko merged 2 commits intoelastic:masterfrom Jun 30, 2020
Merged
Conversation
dmlemeshko
added
backport:skip
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
* master: [ML] Modifies page title to Create job (elastic#70191) [APM] Add API test for service maps (elastic#70185) [DOCS] Adds glossary to documentation (elastic#69721) [Usage Collection] Report nodes feature usage (elastic#70108) chore: improve support for mjs file extension (elastic#70186) [ML] Anomaly Detection: ensure 'Category examples' tab in the expanded table row can be seen (elastic#70241) [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995) Fix typo in bootstrap command (elastic#69976) [code coverage] ingest correct coveredFilePath for mocha (elastic#70215) [Dashboard] Add visualization by value to dashboard (elastic#69898) updates wording in Cases connectors (elastic#70298) [ML] Fix license subscription race condition. (elastic#70074) [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
* [code coverage] ingest correct coveredFilePath for mocha * export variable globally so it is availble in node script
dmlemeshko
deleted the
coverage/fix-data-in-mocha-coveredFilePath-field
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing coveredFilePath for mocha: we ingest wrong value because we do not merge mocha, it is executed under oss-intake and coverage report contains original root path. As for jest and functional we do merge it in other worker, and we later use COVERAGE_INGESTION_KIBANA_ROOT value to clean path.
For mocha we need to override COVERAGE_INGESTION_KIBANA_ROOT with original worker path:
/dev/shm/workspace/kibanajob: https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/862/
Fixed: