[Dashboard] Add visualization by value to dashboard by majagrubic · Pull Request #69898 · elastic/kibana

majagrubic · 2020-06-25T09:20:34Z

Summary

This is a continuation of: #68902

The functionality is the same as in the above-mentioned PR, with a difference that this PR incorporates changes of the new state transfer and removes the hack of passing the dashboard input around.

Reminder: to test this locally, you'll need to set the showNewVisualizeFlow flag to true in visualize/config.ts:
https://github.com/elastic/kibana/pull/68902/files#diff-fce45a432f9c2a705ffc1f2b16fce071R23
Without the flag set, there should be no changes to the existing flow.

Note: Editing visualization does not work yet, will tackle that in a separate PR, to keep this one brief and short.

Tracking issue: https://github.com/elastic/kibana-team/issues/231

Checklist

Delete any items that are not applicable to this PR.

~~- [] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~

Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-06-25T14:16:42Z

Pinging @elastic/kibana-app (Team:KibanaApp)

ThomThomson

Tested on Chrome and Firefox. Everything works as expected, LGTM!

As discussed, in this PR edit visualization doesn't appear as an option on visualizations which were added by value, but this only happens when the feature flag is turned on, so it won't disrupt normal functionality. Additionally, a followup PR will address this.

src/plugins/embeddable/public/lib/state_transfer/types.ts

src/plugins/dashboard/public/application/dashboard_app_controller.tsx

stratoula

LGTM, tested on Chrome. Works fine!

ppisljar

code LGTM!

kibanamachine · 2020-06-30T11:20:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5b16619

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
visualize	184	+5	179

History

💚 Build #56658 succeeded 0e14f42
💚 Build #56293 succeeded 2d4f0e3
💛 Build #56235 was flaky d5bce1f
💚 Build #56227 succeeded a1000cf443996931f6020b7d82f1851976507b00
💔 Build #56223 failed f8da5da1ba749cf13c83cda6581d1fa1125492e8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Plugging in DashboardStart dependency * Create embeddable by reference and navigate back to dashboard * Trying to feature flag the new flow * Feature flagging new visualize flow * Removing unnecessary console statement * Fixing typescript errors * Adding a functional test for new functionality * Adding a functional test for new functionality * Fixing test name * Changing test name * Moving functional test to a separate folder * Trying to fix the config file * Adding an index file * Remove falsly included file * Adding aggs and params to vis input * Serializing vis before passing it as an input * Incorporating new state transfer logic * Remove dashboardStart as a dependency * Trying to get the test to run * Remove unused import * Readding spaces * Fixing type errors * Incorporating new changes # Conflicts: # scripts/functional_tests.js # tasks/function_test_groups.js

* master: [ML] Modifies page title to Create job (elastic#70191) [APM] Add API test for service maps (elastic#70185) [DOCS] Adds glossary to documentation (elastic#69721) [Usage Collection] Report nodes feature usage (elastic#70108) chore: improve support for mjs file extension (elastic#70186) [ML] Anomaly Detection: ensure 'Category examples' tab in the expanded table row can be seen (elastic#70241) [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995) Fix typo in bootstrap command (elastic#69976) [code coverage] ingest correct coveredFilePath for mocha (elastic#70215) [Dashboard] Add visualization by value to dashboard (elastic#69898) updates wording in Cases connectors (elastic#70298) [ML] Fix license subscription race condition. (elastic#70074) [Logs UI] [Alerting] "Group by" functionality (elastic#68250)

* Plugging in DashboardStart dependency * Create embeddable by reference and navigate back to dashboard * Trying to feature flag the new flow * Feature flagging new visualize flow * Removing unnecessary console statement * Fixing typescript errors * Adding a functional test for new functionality * Adding a functional test for new functionality * Fixing test name * Changing test name * Moving functional test to a separate folder * Trying to fix the config file * Adding an index file * Remove falsly included file * Adding aggs and params to vis input * Serializing vis before passing it as an input * Incorporating new state transfer logic * Remove dashboardStart as a dependency * Trying to get the test to run * Remove unused import * Readding spaces * Fixing type errors * Incorporating new changes

bhavyarm · 2020-07-29T14:55:54Z

@majagrubic how do I test this PR on 7.9.0 please? Thanks!

flash1293 · 2020-07-29T14:59:27Z

@bhavyarm Maja is out this week. This feature is behind a flag. You have to set visualize.showNewVisualizeFlow: true in the kibana.yml file.

bhavyarm · 2020-07-29T15:00:01Z

@flash1293 thanks :)

Maja Grubic added 20 commits June 17, 2020 12:23

Plugging in DashboardStart dependency

ab8d873

Create embeddable by reference and navigate back to dashboard

1922ee2

Trying to feature flag the new flow

53719ab

Feature flagging new visualize flow

6c6b1a1

Removing unnecessary console statement

eb4e150

Fixing typescript errors

0df45e2

Adding a functional test for new functionality

857bd18

Adding a functional test for new functionality

786431c

Fixing test name

cb8f3cb

Changing test name

afee45a

Moving functional test to a separate folder

cdfb577

Trying to fix the config file

d7bb297

Adding an index file

74839ec

Remove falsly included file

defaa39

Adding aggs and params to vis input

0bb50b9

Serializing vis before passing it as an input

811cba1

Merge branch 'master' into add-vis-to-dashboard

dd1f287

Merge master

ba3286f

Merge master

7a6a891

Incorporating new state transfer logic

5aeb2b2

majagrubic changed the title ~~[Dashobard] Add visualization by value to dashboard~~ [Dashboard] Add visualization by value to dashboard Jun 25, 2020

majagrubic force-pushed the add-vis-to-dashboard-app-communication branch 2 times, most recently from a1000cf to fb45797 Compare June 25, 2020 09:42

Remove dashboardStart as a dependency

d5bce1f

majagrubic force-pushed the add-vis-to-dashboard-app-communication branch from fb45797 to d5bce1f Compare June 25, 2020 09:59

majagrubic mentioned this pull request Jun 25, 2020

[Dashboard] Add visualization by value to Dashboard #68902

Closed

5 tasks

Trying to get the test to run

2d4f0e3

majagrubic added v8.0.0 v7.9.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Jun 25, 2020

majagrubic marked this pull request as ready for review June 25, 2020 14:16

majagrubic requested a review from a team June 25, 2020 14:16

majagrubic requested a review from a team as a code owner June 25, 2020 14:16

botelastic bot added the Feature:Embedding Embedding content via iFrame label Jun 25, 2020

majagrubic requested review from ThomThomson, ppisljar and stratoula June 25, 2020 14:20

ThomThomson approved these changes Jun 25, 2020

View reviewed changes

src/plugins/embeddable/public/lib/state_transfer/types.ts Outdated Show resolved Hide resolved

src/plugins/dashboard/public/application/dashboard_app_controller.tsx Outdated Show resolved Hide resolved

Maja Grubic added 3 commits June 26, 2020 13:25

Merge master

49b0feb

Remove unused import

4862bbf

Readding spaces

0e14f42

stratoula approved these changes Jun 29, 2020

View reviewed changes

ppisljar approved these changes Jun 29, 2020

View reviewed changes

Maja Grubic added 3 commits June 30, 2020 08:39

Merge master

ad84e2e

Fixing type errors

fc4d5cb

Incorporating new changes

5b16619

majagrubic merged commit 7c352c0 into elastic:master Jun 30, 2020

majagrubic deleted the add-vis-to-dashboard-app-communication branch June 30, 2020 11:38

majagrubic mentioned this pull request Jun 30, 2020

[7.x] [Dashboard] Add visualization by value to dashboard (#69898) #70317

Closed

majagrubic mentioned this pull request Jun 30, 2020

[7.x] [Dashboard] Add visualization by value to dashboard (#69898) #70322

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[Dashboard] Add visualization by value to dashboard#69898

[Dashboard] Add visualization by value to dashboard#69898
majagrubic merged 28 commits intoelastic:masterfrom
majagrubic:add-vis-to-dashboard-app-communication

majagrubic commented Jun 25, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jun 25, 2020

Uh oh!

ThomThomson left a comment

Uh oh!

Uh oh!

Uh oh!

stratoula left a comment

Uh oh!

ppisljar left a comment

Uh oh!

kibanamachine commented Jun 30, 2020

Uh oh!

bhavyarm commented Jul 29, 2020

Uh oh!

flash1293 commented Jul 29, 2020

Uh oh!

bhavyarm commented Jul 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Comments

Conversation

majagrubic commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jun 25, 2020

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 30, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

Uh oh!

bhavyarm commented Jul 29, 2020

Uh oh!

flash1293 commented Jul 29, 2020

Uh oh!

bhavyarm commented Jul 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

majagrubic commented Jun 25, 2020 •

edited

Loading