[Monitoring] Added cloud as an optional dependency#69050
Merged
igoristic merged 1 commit intoelastic:masterfrom Jun 12, 2020
Merged
[Monitoring] Added cloud as an optional dependency#69050igoristic merged 1 commit intoelastic:masterfrom
igoristic merged 1 commit intoelastic:masterfrom
Conversation
igoristic
added
bug
Contributor
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
chrisronline
approved these changes
Jun 12, 2020
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
I don't think we can really test this on cloud before merging, but I think this is what we need to do.
LGTM!
Contributor
Author
++. This PR now makes the |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Jun 12, 2020
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Jun 12, 2020
# Conflicts: # x-pack/plugins/monitoring/kibana.json
igoristic
added a commit
that referenced
this pull request
Jun 13, 2020
igoristic
added a commit
that referenced
this pull request
Jun 13, 2020
Contributor
Author
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 15, 2020
* master: (91 commits) [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116) [Observability] Create context container to enable Observability plugin registry function (elastic#68642) Rename space id for disabled index pattern test (elastic#68990) skip flaky suite (elastic#63339) Resolver Light Theme And Kibana Integration (elastic#67859) [kbn/dev-utils] expose public tooling_log module (elastic#68868) index pattern(s) take dependencies as object (elastic#69055) include ci-stats metrics in pr comment (elastic#68563) Bump webpack packages (elastic#68716) [Uptime] Fixed metric query broken because of missing mapping (elastic#68999) Added cloud as an optional dependency (elastic#69050) Fixed all external links (elastic#68614) [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069) [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577) [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067) [ML] Fix cloud deployment ID check (elastic#68695) [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033) Add ingest manager topic to docs (elastic#68980) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582) [DOCS] Fixes POST request for saved objects (elastic#69036) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 15, 2020
* master: (60 commits) Re-enable mistakenly skipped tests. (elastic#69123) [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116) [Observability] Create context container to enable Observability plugin registry function (elastic#68642) Rename space id for disabled index pattern test (elastic#68990) skip flaky suite (elastic#63339) Resolver Light Theme And Kibana Integration (elastic#67859) [kbn/dev-utils] expose public tooling_log module (elastic#68868) index pattern(s) take dependencies as object (elastic#69055) include ci-stats metrics in pr comment (elastic#68563) Bump webpack packages (elastic#68716) [Uptime] Fixed metric query broken because of missing mapping (elastic#68999) Added cloud as an optional dependency (elastic#69050) Fixed all external links (elastic#68614) [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069) [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577) [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067) [ML] Fix cloud deployment ID check (elastic#68695) [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033) Add ingest manager topic to docs (elastic#68980) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68933
We have some
isCloudEnabledlogic that wasn't working simply because we did not include the "cloud" plugin in our kibana.json file