[Uptime] Fixed metric query broken because of missing mapping

[shahzad31]

Summary

Fixes: #69000

Make sure to access fields only when they are present in scripted metric query.

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[andrewvc]

LGTM Pending @justinkambic 's approval. Had to add some brackets

[justinkambic]

I tested this locally as well (failure on master/7.8, succeeds with this patch), LGTM

[justinkambic]

I re-tested to ensure the monitor details page shows the x509 field data correctly. Still LGTM

[kibanamachine]

💛 Build succeeded, but was flaky

• continuous-integration/kibana-ci/pull-request
• Commit: 78c7742
• Flaky suites:
  • kibana-ciGroup1

---

Test Failures

Kibana Pipeline / kibana-oss-agent / Example plugin functional tests.test/examples/embeddables/adding_children·ts.embeddable explorer creating and adding children Can create a new child

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 9 times on tracked branches: https://github.com/elastic/kibana/issues/58692

[00:00:00]       │
[00:00:28]         └-: embeddable explorer
[00:00:28]           └-> "before all" hook
[00:00:28]           └-> "before all" hook
[00:00:28]             │ debg navigating to embeddableExplorer url: http://localhost:6121/app/embeddableExplorer
[00:00:28]             │ debg navigate to: http://localhost:6121/app/embeddableExplorer
[00:00:28]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591979424286248319] [.kibana] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:00:28]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591979424286248319] [.kibana/PmChlKdJQW253Eio46q_pw] create_mapping
[00:00:29]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591979424286248319] [.kibana/PmChlKdJQW253Eio46q_pw] update_mapping [_doc]
[00:00:29]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591979424286248319] [.kibana/PmChlKdJQW253Eio46q_pw] update_mapping [_doc]
[00:00:29]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting application changed to undefined"
[00:00:29]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting application changed to undefined"
[00:00:29]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Error Sending Metrics Report TypeError: Failed to fetch"
[00:00:29]             │ debg browser[INFO] http://localhost:6121/app/embeddableExplorer?_t=1591981508123 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:29]             │
[00:00:29]             │ debg browser[INFO] http://localhost:6121/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:29]             │ debg ... sleep(700) start
[00:00:30]             │ debg ... sleep(700) end
[00:00:30]             │ debg returned from get, calling refresh
[00:00:30]             │ debg browser[INFO] http://localhost:6121/app/embeddableExplorer?_t=1591981508123 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:30]             │
[00:00:30]             │ debg browser[INFO] http://localhost:6121/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:30]             │ debg currentUrl = http://localhost:6121/app/embeddableExplorer
[00:00:30]             │          appUrl = http://localhost:6121/app/embeddableExplorer
[00:00:30]             │ debg TestSubjects.find(kibanaChrome)
[00:00:30]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:32]             │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/plugin/testbed/testbed.plugin.js 172:12 "Testbed plugin set up. uiProp: 'Accessible from client'"
[00:00:32]             │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core/core.entry.js 44017:18 "App [dev_tools] is using deprecated mount context. Use core.getStartServices() instead."
[00:00:32]             │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 395:106115 "INFO: 2020-06-12T17:05:11Z
[00:00:32]             │        Adding connection to http://localhost:6121/elasticsearch
[00:00:32]             │
[00:00:32]             │      "
[00:00:32]             │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core/core.entry.js 44017:18 "App [management] is using deprecated mount context. Use core.getStartServices() instead."
[00:00:32]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting user-agent."
[00:00:32]             │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/plugin/testbed/testbed.plugin.js 180:12 "Testbed plugin started"
[00:00:32]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting application changed to embeddableExplorer"
[00:00:32]             │ debg ... sleep(501) start
[00:00:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591979424286248319] [.kibana/PmChlKdJQW253Eio46q_pw] update_mapping [_doc]
[00:00:32]             │ debg ... sleep(501) end
[00:00:32]             │ debg in navigateTo url = http://localhost:6121/app/embeddableExplorer
[00:00:32]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:32]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:35]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:38]           └-: creating and adding children
[00:00:38]             └-> "before all" hook
[00:00:38]             └-> "before all" hook
[00:00:38]               │ debg TestSubjects.click(embeddablePanelExamplae)
[00:00:38]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelExamplae"]') with timeout=10000
[00:00:38]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelExamplae"]') with timeout=10000
[00:00:38]             └-> Can create a new child
[00:00:38]               └-> "before each" hook: global before each
[00:00:38]               │ debg TestSubjects.click(embeddablePanelToggleMenuIcon)
[00:00:38]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=10000
[00:00:38]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=10000
[00:00:38]               │ debg TestSubjects.click(embeddablePanelAction-ACTION_ADD_PANEL)
[00:00:38]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelAction-ACTION_ADD_PANEL"]') with timeout=10000
[00:00:38]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelAction-ACTION_ADD_PANEL"]') with timeout=10000
[00:00:38]               │ debg TestSubjects.click(createNew)
[00:00:38]               │ debg Find.clickByCssSelector('[data-test-subj="createNew"]') with timeout=10000
[00:00:38]               │ debg Find.findByCssSelector('[data-test-subj="createNew"]') with timeout=10000
[00:00:39]               │ debg TestSubjects.click(createNew-TODO_EMBEDDABLE)
[00:00:39]               │ debg Find.clickByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:00:39]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:00:49]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:00:49]               │      Wait timed out after 10041ms
[00:00:49]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:00:59]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:00:59]               │      Wait timed out after 10018ms
[00:01:00]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:10]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:10]               │      Wait timed out after 10037ms
[00:01:10]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:20]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:20]               │      Wait timed out after 10052ms
[00:01:21]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:31]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:31]               │      Wait timed out after 10037ms
[00:01:31]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:41]               │ debg --- retry.try failed again with the same message...
[00:01:42]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:52]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:52]               │      Wait timed out after 10028ms
[00:01:52]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:02]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:02]               │      Wait timed out after 10040ms
[00:02:03]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:13]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:13]               │      Wait timed out after 10031ms
[00:02:13]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:23]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:23]               │      Wait timed out after 10008ms
[00:02:24]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:34]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:34]               │      Wait timed out after 10054ms
[00:02:35]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:45]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:45]               │      Wait timed out after 10038ms
[00:02:45]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/embeddable explorer creating and adding children Can create a new child.png"
[00:02:45]               │ info Current URL is: http://localhost:6121/app/embeddableExplorer/embeddablePanelExamplae
[00:02:45]               │ info Saving page source to: /dev/shm/workspace/kibana/test/examples/failure_debug/html/embeddable explorer creating and adding children Can create a new child.html
[00:02:45]               └- ✖ fail: "embeddable explorer creating and adding children Can create a new child"
[00:02:45]               │

Stack Trace

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
Wait timed out after 10038ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

---

History

• 💚 Build #53599 succeeded ce34d8b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream