Skip to content

Comments

include ci-stats metrics in pr comment#68563

Merged
spalger merged 7 commits intoelastic:masterfrom
spalger:implement/ci-stats/metrics-report
Jun 12, 2020
Merged

include ci-stats metrics in pr comment#68563
spalger merged 7 commits intoelastic:masterfrom
spalger:implement/ci-stats/metrics-report

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Jun 8, 2020 •
edited
Loading

The culmination of a bunch of work we've done to keep track of key metrics as changes are submitted in PRs. These metrics are collected during the build and reported to the kibana-ci-stats service, where they are indexed into ES.
Once the build is complete a request is sent to the kibana-ci-stats service to fetch a report, formatted in markdown, and then that report is included in the comment left by our CI tooling.

Examples of comment formatting

None of the build metrics changed:

💚 Build Succeeded

Build metrics

✅ unchanged

History

...

The build succeeded but the build metrics couldn't be found becuase the baseline build for that commit failed:

💚 Build Succeeded

Build metrics

‼️ unable to find a baseline build for [branch@sha]. Try merging the upstream branch and trying again.

History

...

The build succeeded and there were some changes to the bundles which caused them to grow in size and module count:

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
telemetry 13 +3 10
licenseManagement 273 +3 270
total - +6 -

page load asset size

id value diff baseline
/bundles/plugin/telemetry/telemetry.plugin.js 88.0KB +12.1KB 75.9KB
total - +12.1KB -

History

...

@spalger spalger force-pushed the implement/ci-stats/metrics-report branch from 3dc6a35 to 703fb16 Compare June 8, 2020 21:06
@spalger spalger force-pushed the implement/ci-stats/metrics-report branch from d0a7a02 to ded15c0 Compare June 9, 2020 23:46
@spalger spalger marked this pull request as ready for review June 10, 2020 05:28
@spalger spalger requested a review from a team as a code owner June 10, 2020 05:28
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.8.0 v7.9.0 v8.0.0 labels Jun 10, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 10, 2020

Pinging @elastic/kibana-operations (Team:Operations)

@spalger
Copy link
Contributor Author

spalger commented Jun 10, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Jun 10, 2020

@elasticmachine merge upstream

mshustov
mshustov reviewed Jun 10, 2020
View reviewed changes
vars/githubPr.groovy
}

messages << getTestFailuresMessage()
messages << ciStats.getMetricsReport()
Copy link
Contributor

@mshustov mshustov Jun 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for self-education: how is it mapped to a function or remote call? ok, found kibana-pipeline-library

@spalger spalger mentioned this pull request Jun 10, 2020
Closed
7 tasks
@spalger
Copy link
Contributor Author

spalger commented Jun 11, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 11, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 0577f9b into elastic:master Jun 12, 2020
@spalger spalger deleted the implement/ci-stats/metrics-report branch June 12, 2020 23:37
@spalger spalger mentioned this pull request Jun 12, 2020
Merged
spalger added a commit to spalger/kibana that referenced this pull request Jun 12, 2020
@spalger @elasticmachine
include ci-stats metrics in pr comment (elastic#68563)
08510b6 
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger mentioned this pull request Jun 12, 2020
Merged
spalger added a commit to spalger/kibana that referenced this pull request Jun 12, 2020
@spalger @elasticmachine
include ci-stats metrics in pr comment (elastic#68563)
0b72c3a 
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	Jenkinsfile
spalger added a commit that referenced this pull request Jun 13, 2020
@spalger @elasticmachine
[7.8] include ci-stats metrics in pr comment (#68563) (#69097)
63c2521 
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	Jenkinsfile
spalger added a commit that referenced this pull request Jun 13, 2020
@spalger @elasticmachine
[7.x] include ci-stats metrics in pr comment (#68563) (#69096)
5495552 
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 15, 2020
@gmmorris
Merge branch 'master' into actions/execute-immediate
896b9a5 
* master: (91 commits)
  [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116)
  [Observability] Create context container to enable Observability plugin registry function (elastic#68642)
  Rename space id for disabled index pattern test (elastic#68990)
  skip flaky suite (elastic#63339)
  Resolver Light Theme And Kibana Integration (elastic#67859)
  [kbn/dev-utils] expose public tooling_log module (elastic#68868)
  index pattern(s) take dependencies as object (elastic#69055)
  include ci-stats metrics in pr comment (elastic#68563)
  Bump webpack packages (elastic#68716)
  [Uptime] Fixed metric query broken because of missing mapping (elastic#68999)
  Added cloud as an optional dependency (elastic#69050)
  Fixed all external links (elastic#68614)
  [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069)
  [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577)
  [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067)
  [ML] Fix cloud deployment ID check (elastic#68695)
  [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033)
  Add ingest manager topic to docs (elastic#68980)
  [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582)
  [DOCS] Fixes POST request for saved objects (elastic#69036)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 15, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
f34d031 
* master: (60 commits)
  Re-enable mistakenly skipped tests. (elastic#69123)
  [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116)
  [Observability] Create context container to enable Observability plugin registry function (elastic#68642)
  Rename space id for disabled index pattern test (elastic#68990)
  skip flaky suite (elastic#63339)
  Resolver Light Theme And Kibana Integration (elastic#67859)
  [kbn/dev-utils] expose public tooling_log module (elastic#68868)
  index pattern(s) take dependencies as object (elastic#69055)
  include ci-stats metrics in pr comment (elastic#68563)
  Bump webpack packages (elastic#68716)
  [Uptime] Fixed metric query broken because of missing mapping (elastic#68999)
  Added cloud as an optional dependency (elastic#69050)
  Fixed all external links (elastic#68614)
  [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069)
  [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577)
  [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067)
  [ML] Fix cloud deployment ID check (elastic#68695)
  [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033)
  Add ingest manager topic to docs (elastic#68980)
  [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

+1 more reviewer

@mshustov mshustov mshustov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spalger @elasticmachine @kibanamachine @tylersmalley @mshustov