[SIEM] Add create template button by angorayc · Pull Request #66613 · elastic/kibana

angorayc · 2020-05-14T18:49:23Z

Summary

This PR is to add create template timeline button.
To verify this PR please go to x-pack/plugins/siem/common/constants.ts Line 149 and change disableTemplate into false;

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~
~~This renders correctly on smaller devices using a responsive layout. (You can test this in your browser~~
~~This was checked for cross-browser compatibility, including a check against IE11~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~

elasticmachine · 2020-05-14T18:49:25Z

Pinging @elastic/siem (Team:SIEM)

angorayc · 2020-06-01T09:37:14Z

@elasticmachine merge upstream

angorayc · 2020-06-04T21:30:30Z

@elasticmachine merge upstream

angorayc · 2020-06-05T06:23:14Z

@elasticmachine merge upstream

…te-btn

angorayc · 2020-06-05T14:47:39Z

@elasticmachine merge upstream

x-pack/plugins/security_solution/server/lib/timeline/routes/update_timelines_route.ts

x-pack/plugins/security_solution/server/lib/timeline/routes/get_draft_timelines_route.ts

x-pack/plugins/security_solution/server/lib/timeline/routes/clean_draft_timelines_route.ts

…te-btn

angorayc · 2020-06-08T09:33:19Z

@elasticmachine merge upstream

patrykkopycinski · 2020-06-09T07:03:03Z

@elasticmachine merge upstream

patrykkopycinski

LGTM! As we have discussed let's have it merged and any findings are going to fixed in #67837

kibanamachine · 2020-06-09T09:45:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4e1ec59

History

💚 Build #52441 succeeded 9161f97
💚 Build #52354 succeeded 7749f4c
💔 Build #52331 failed 89ad223
💚 Build #52101 succeeded 5244333
💚 Build #52078 succeeded 570f917

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* add template btn * rename file * unit test * replace connector with useDispatch * comments * add disableTemplate * rename flag * fix types * remove snapshot * fix types * add fix action * move disableTemplate flag into constants * fix types * Fix timelineType * button style * unit test * unit test * fix types * Update x-pack/plugins/siem/public/timelines/components/timeline/properties/create_timeline_btn.tsx Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> * fix unit test * add unit test * add unit test * fix types * fix tests * fix unit * fix i18n key * remove snapshot * fix crud * fix crud * fix unit * fix tag * fix unit * disable template timeline * Update use_create_timeline.tsx Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

* add template btn * rename file * unit test * replace connector with useDispatch * comments * add disableTemplate * rename flag * fix types * remove snapshot * fix types * add fix action * move disableTemplate flag into constants * fix types * Fix timelineType * button style * unit test * unit test * fix types * Update x-pack/plugins/siem/public/timelines/components/timeline/properties/create_timeline_btn.tsx Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> * fix unit test * add unit test * add unit test * fix types * fix tests * fix unit * fix i18n key * remove snapshot * fix crud * fix crud * fix unit * fix tag * fix unit * disable template timeline * Update use_create_timeline.tsx Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

* master: (37 commits) [DOCS] Adds documentation for drilldowns (elastic#68122) [Telemetry] telemetry.sendUsageFrom: "server" by default (elastic#68071) [ML] Transforms: Support sub-aggregations (elastic#68306) Fixed pre-configured docs link points to the wrong page and functional tests configs (elastic#68606) [Ingest Manager] Update queries from `stream.*` to `dataset.*` (elastic#68322) Enable Watcher by default to fix bug in which Watcher doesn't render in the side nav (elastic#68602) Convert Index Templates API routes to snakecase. (elastic#68463) [SECURITY SOLUTION] [Detections] Add / Update e2e tests to ensure initial rule runs are successful (elastic#68441) [Ingest] OpenAPI spec file (elastic#68323) chore(NA): skip apis Endpoint plugin Endpoint policy api (elastic#68638) bumping makelogs version to v6.0.0 (elastic#66163) [SIEM] Add create template button (elastic#66613) Bump websocket-extensions from 0.1.3 to 0.1.4 (elastic#68414) [ML] Sample data modules - use event.dataset instead of index name (elastic#68538) [ML] Functional tests - fix job validation API test with maxModelMemoryLimit (elastic#68501) [ML] Functional tests - stabilize DFA job creation (elastic#68495) [TSVB] Allows the user to change the tooltip mode (elastic#67775) chore(NA): skip apis Endpoint plugin Endpoint alert API when data is in elasticsearch (elastic#68613) chore(NA): skip endpoint Endpoint Alert Page: when es has data and user has navigated to the page (elastic#68596) [SIEM][Detection Engine] Converts from joi to use io-ts and moves the types to common (elastic#68127) ...

elasticmachine · 2021-09-23T14:34:24Z

Pinging @elastic/security-solution (Team: SecuritySolution)

angorayc added 4 commits May 13, 2020 19:51

add template btn

6031d22

rename file

c38e8ac

Merge remote-tracking branch 'upstream/master' into template-btn

d9dc0b7

unit test

b5df002

angorayc added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 14, 2020

angorayc added 5 commits May 15, 2020 09:30

Merge remote-tracking branch 'upstream/master' into template-btn

22c875c

Merge remote-tracking branch 'upstream/master' into template-btn

37ee874

replace connector with useDispatch

9d8bae5

Merge remote-tracking branch 'upstream/master' into template-btn

6c806a0

comments

d8ce05b

angorayc added v7.9.0 and removed v7.8.0 labels May 17, 2020

angorayc added 2 commits May 18, 2020 13:44

add disableTemplate

f41170f

rename flag

42aabde

angorayc marked this pull request as ready for review May 18, 2020 14:27

angorayc requested review from a team as code owners May 18, 2020 14:27

angorayc added 3 commits May 18, 2020 15:59

Merge remote-tracking branch 'upstream/master' into template-btn

7244827

fix types

6d36589

remove snapshot

38686d7

angorayc force-pushed the template-btn branch 2 times, most recently from 10ccac0 to 38686d7 Compare May 28, 2020 21:15

angorayc added 2 commits May 28, 2020 22:30

Merge remote-tracking branch 'upstream/master' into template-btn

20075bc

fix types

a28f04f

Merge branch 'master' into template-btn

2a70bb6

remove snapshot

d989582

Merge branch 'master' into template-btn

1871a75

elasticmachine and others added 5 commits June 4, 2020 23:23

Merge branch 'master' into template-btn

56a47af

fix crud

c8313a4

fix crud

5e7c7b4

Merge branch 'template-btn' of github.com:angorayc/kibana into templa…

3ea0722

…te-btn

fix unit

5705d2e

Merge branch 'master' into template-btn

570f917

patrykkopycinski reviewed Jun 5, 2020

View reviewed changes

angorayc added 2 commits June 5, 2020 16:41

fix tag

ad24a6a

Merge branch 'template-btn' of github.com:angorayc/kibana into templa…

5244333

…te-btn

elasticmachine and others added 3 commits June 8, 2020 02:33

Merge branch 'master' into template-btn

89ad223

fix unit

7749f4c

disable template timeline

9161f97

Merge branch 'master' into template-btn

53479e8

patrykkopycinski approved these changes Jun 9, 2020

View reviewed changes

Update use_create_timeline.tsx

4e1ec59

angorayc merged commit 88f252a into elastic:master Jun 9, 2020

angorayc mentioned this pull request Jun 9, 2020

[7.x] [SIEM] Add create template button (#66613) #68635

Merged

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Add create template button#66613

[SIEM] Add create template button#66613
angorayc merged 51 commits intoelastic:masterfrom
angorayc:template-btn

angorayc commented May 14, 2020 •

edited

Loading

Uh oh!

elasticmachine commented May 14, 2020

Uh oh!

angorayc commented Jun 1, 2020

Uh oh!

angorayc commented Jun 4, 2020

Uh oh!

angorayc commented Jun 5, 2020

Uh oh!

angorayc commented Jun 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

angorayc commented Jun 8, 2020

Uh oh!

patrykkopycinski commented Jun 9, 2020

Uh oh!

patrykkopycinski left a comment

Uh oh!

kibanamachine commented Jun 9, 2020

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

angorayc commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented May 14, 2020

Uh oh!

angorayc commented Jun 1, 2020

Uh oh!

angorayc commented Jun 4, 2020

Uh oh!

angorayc commented Jun 5, 2020

Uh oh!

angorayc commented Jun 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

angorayc commented Jun 8, 2020

Uh oh!

patrykkopycinski commented Jun 9, 2020

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 9, 2020

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

angorayc commented May 14, 2020 •

edited

Loading