[Ingest Manager] Update queries from stream.* to dataset.*#68322
Merged
ruflin merged 3 commits intoelastic:masterfrom Jun 9, 2020
Merged
[Ingest Manager] Update queries from stream.* to dataset.*#68322ruflin merged 3 commits intoelastic:masterfrom
stream.* to dataset.*#68322ruflin merged 3 commits intoelastic:masterfrom
Conversation
jen-huang
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
Author
|
@skh @neptunian Could you please review the above linked issue & PR and let me know if you think there is anything else we need to change on the EPM side? |
8 tasks
neptunian
approved these changes
Jun 4, 2020
skh
approved these changes
Jun 5, 2020
Contributor
skh
left a comment
skh
left a comment
There was a problem hiding this comment.
I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names.
That's correct. 👍
Contributor
|
Change LGTM. I'll make sure all the related PR's are merged closely together so we don't have any failing builds. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ruflin
changed the title
stream.* to dataset.*stream.* to dataset.*
Contributor
|
Tested together with elastic/beats#18967 and works as expected. Merging. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 9, 2020
* master: (37 commits) [DOCS] Adds documentation for drilldowns (elastic#68122) [Telemetry] telemetry.sendUsageFrom: "server" by default (elastic#68071) [ML] Transforms: Support sub-aggregations (elastic#68306) Fixed pre-configured docs link points to the wrong page and functional tests configs (elastic#68606) [Ingest Manager] Update queries from `stream.*` to `dataset.*` (elastic#68322) Enable Watcher by default to fix bug in which Watcher doesn't render in the side nav (elastic#68602) Convert Index Templates API routes to snakecase. (elastic#68463) [SECURITY SOLUTION] [Detections] Add / Update e2e tests to ensure initial rule runs are successful (elastic#68441) [Ingest] OpenAPI spec file (elastic#68323) chore(NA): skip apis Endpoint plugin Endpoint policy api (elastic#68638) bumping makelogs version to v6.0.0 (elastic#66163) [SIEM] Add create template button (elastic#66613) Bump websocket-extensions from 0.1.3 to 0.1.4 (elastic#68414) [ML] Sample data modules - use event.dataset instead of index name (elastic#68538) [ML] Functional tests - fix job validation API test with maxModelMemoryLimit (elastic#68501) [ML] Functional tests - stabilize DFA job creation (elastic#68495) [TSVB] Allows the user to change the tooltip mode (elastic#67775) chore(NA): skip apis Endpoint plugin Endpoint alert API when data is in elasticsearch (elastic#68613) chore(NA): skip endpoint Endpoint Alert Page: when es has data and user has navigated to the page (elastic#68596) [SIEM][Detection Engine] Converts from joi to use io-ts and moves the types to common (elastic#68127) ...
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Jun 9, 2020
…ic#68322) Resolves elastic#67672 Part of elastic/package-registry#491 See elastic/package-registry#492 for package registry changes. Updates existing queries to use `dataset.*` fields. from `stream.*` fields. I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
jen-huang
added a commit
that referenced
this pull request
Jun 9, 2020
… (#68667) Resolves #67672 Part of elastic/package-registry#491 See elastic/package-registry#492 for package registry changes. Updates existing queries to use `dataset.*` fields. from `stream.*` fields. I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #67672
Part of elastic/package-registry#491
See elastic/package-registry#492 for package registry changes.
Updates existing queries to use
dataset.*fields. fromstream.*fields.I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. nginx package info) is not affected by the current package registry changes.