[Security Solution] Manage timeline templates user flow#67837
Merged
patrykkopycinski merged 140 commits intoelastic:masterfrom Jul 9, 2020
Merged
[Security Solution] Manage timeline templates user flow#67837patrykkopycinski merged 140 commits intoelastic:masterfrom
patrykkopycinski merged 140 commits intoelastic:masterfrom
Conversation
…imeline-template-flow # Conflicts: # x-pack/plugins/siem/public/timelines/components/timeline/properties/helpers.tsx
Contributor
Author
|
@elasticmachine merge upstream |
…kkopycinski/kibana into feat/create-timeline-template-flow
XavierM
reviewed
Jul 9, 2020
Contributor
|
when I tried to create a rule and pick my template timeline, I cannot. I do not think we set up the right parameters for the query. It should be only
|
XavierM
approved these changes
Jul 9, 2020
Contributor
XavierM
left a comment
XavierM
left a comment
There was a problem hiding this comment.
Good job on this feature, it was not an easy one. You show a lot of patience and dexterity. But mostly, it is working as expected. 💪 🎸 💪 🎸 🏄
Contributor
Author
|
@elasticmachine merge upstream |
angorayc
approved these changes
Jul 9, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jul 9, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Jul 9, 2020
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Templates tab:
Create template flyout:
Add field to the template:
Regular field in template view:
Template field:
Covert between field types in template:
Added ability to create a new timeline from a specific template
Improvements:
Checklist
Delete any items that are not applicable to this PR.
For maintainers