Skip to content

[SIEM] [Cases] Fixes 500 error on push_case route#65387

Merged
stephmilovic merged 1 commit intoelastic:masterfrom
stephmilovic:fix-case-push-server-bug
May 6, 2020
Merged

[SIEM] [Cases] Fixes 500 error on push_case route#65387
stephmilovic merged 1 commit intoelastic:masterfrom
stephmilovic:fix-case-push-server-bug

Conversation

@stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented May 5, 2020

Summary

We were checking the closure_type of the default configuration, when you are able to push a case without ever setting a default configuration. Adds a check if the default exists, and tests.

Steps to reproduce and a screenshot of the error:

  • start with no 'cases-configure' saved objects (either by deleting this SO type from your index or deleting your index)
  • create a Jira connector
  • do NOT save the connector as the default
  • create a new case
  • use the External Services dropdown to select Jira as the connector
  • push
    • error behavior: does not push

Screenshot 2020-05-05 at 20 45 22

Checklist

Delete any items that are not applicable to this PR.

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 5, 2020
@stephmilovic stephmilovic requested review from a team as code owners May 5, 2020 22:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit edc8cb5 into elastic:master May 6, 2020
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request May 6, 2020
@stephmilovic stephmilovic deleted the fix-case-push-server-bug branch May 6, 2020 03:13
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 6, 2020
* master: (72 commits)
  add tsvb tests to Firefox suite (elastic#65425)
  Fix flaky ServerMetricsCollector integration test (elastic#65420)
  [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428)
  [ML] Adds docs_per_second to transform edit form. (elastic#65365)
  update apm index pattern (elastic#65424)
  add direct build command (elastic#65431)
  [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417)
  [chore] Improve request cancelation handling in vis embeddable (elastic#65057)
  [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888)
  [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290)
  Additional branding updates (elastic#64712)
  Remove redundant formatting of percentage column (elastic#64948)
  [SIEM][CASE] Configuration pages UI redesign (elastic#65355)
  New nav (elastic#64018)
  [Ingest pipelines] Address copy feedback (elastic#65175)
  bug fixing (elastic#65387)
  skip whole suite blocking snapshots (elastic#65377)
  add related event generation to ancestor nodes (fixes a bug) (elastic#64950)
  [Canvas] move files from legacy/plugins to plugins (elastic#65283)
  [SIEM] template timeline UI (elastic#64439)
  ...
stephmilovic added a commit that referenced this pull request May 6, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments