[ML] Transforms: Adds docs_per_second to transform edit form.#65365
[ML] Transforms: Adds docs_per_second to transform edit form.#65365walterra merged 1 commit intoelastic:masterfrom
Conversation
|
Pinging @elastic/ml-ui (:ml) |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Firefox XPack UI Functional Tests.x-pack/test/functional/apps/infra/home_page·ts.InfraOps app Home page without metrics present renders an empty data promptStandard OutStack TraceTo update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
|
user doesn't have permission to update head repository |
|
jenkins retest |
peteharverson
left a comment
There was a problem hiding this comment.
A couple of comments for follow-ups, but otherwise LGTM.
| 'xpack.transform.transformList.editFlyoutFormDocsPerSecondHelptext', | ||
| { | ||
| defaultMessage: | ||
| 'To enable throttling, set a limit of documents per second of input documents.', |
There was a problem hiding this comment.
One for a follow-up - is there any guidance we can give as to what is a sensible value here?
| return { | ||
| ...state, | ||
| errorMessages: state.isOptional && value.length === 0 ? [] : validate[state.validator](value), | ||
| errorMessages: |
There was a problem hiding this comment.
If the update fails, a toast notification is correctly displayed. But when I dismiss the toast, the flyout closes, not allowing the user to correct any mistakes. The flyout should remain open after the toast error is dismissed.
There was a problem hiding this comment.
Good find, will be solved in a follow-up.
Adds an option to edit the docs_per_second option for throttling for transforms.
* master: (72 commits) add tsvb tests to Firefox suite (elastic#65425) Fix flaky ServerMetricsCollector integration test (elastic#65420) [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428) [ML] Adds docs_per_second to transform edit form. (elastic#65365) update apm index pattern (elastic#65424) add direct build command (elastic#65431) [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417) [chore] Improve request cancelation handling in vis embeddable (elastic#65057) [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888) [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290) Additional branding updates (elastic#64712) Remove redundant formatting of percentage column (elastic#64948) [SIEM][CASE] Configuration pages UI redesign (elastic#65355) New nav (elastic#64018) [Ingest pipelines] Address copy feedback (elastic#65175) bug fixing (elastic#65387) skip whole suite blocking snapshots (elastic#65377) add related event generation to ancestor nodes (fixes a bug) (elastic#64950) [Canvas] move files from legacy/plugins to plugins (elastic#65283) [SIEM] template timeline UI (elastic#64439) ...
Summary
Fixes #62740.
Adds an option to edit the
docs_per_secondoption for throttling for transforms.Checklist
Delete any items that are not applicable to this PR.
For maintainers