Skip to content

Comments

[Canvas] move files from legacy/plugins to plugins#65283

Merged
crob611 merged 7 commits intoelastic:masterfrom
crob611:canvas-move-files
May 6, 2020
Merged

[Canvas] move files from legacy/plugins to plugins#65283
crob611 merged 7 commits intoelastic:masterfrom
crob611:canvas-move-files

Conversation

@crob611
Copy link
Contributor

@crob611 crob611 commented May 5, 2020

Like the title says, this is moving all of the files from x-pack/legacy/plugins/canvas to x-pack/plugins/canvas. Overall result should be a no-op.

I broke this up into a handful of commits to maybe make it easier to review the changes.

Moves the files

Correct paths to Canvas

Correct paths in Canvas

Fix shareable_runtime and storybook paths

@crob611 crob611 requested review from a team as code owners May 5, 2020 15:34
@crob611 crob611 added loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.8.0 v8.0.0 labels May 5, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented May 5, 2020

Pinging @elastic/kibana-canvas (Team:Canvas)

ryankeairns
ryankeairns approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for design; no changes, just relocated files.

@crob611
Copy link
Contributor Author

crob611 commented May 5, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented May 5, 2020

user doesn't have permission to update head repository

poffdeluxe
poffdeluxe approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move looks good to me

cqliu1
cqliu1 approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I checked our Canvas scripts, and all of the them are working as expected.

@spong
Copy link
Member

spong commented May 5, 2020

FYI -- the SIEM Cypress Tests flakiness around cases_connectors.spec.ts has been resolved in master, so you should be 👍 after grabbing the latest.

@kibanamachine
Copy link
Contributor

kibanamachine commented May 6, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit b8bea5b into elastic:master May 6, 2020
@crob611 crob611 mentioned this pull request May 6, 2020
Merged
crob611 pushed a commit to crob611/kibana that referenced this pull request May 6, 2020
[Canvas] move files from legacy/plugins to plugins (elastic#65283)
04f439e 
* Moves the files

* Rename legacy/plugins/canvas paths

* Correct paths

* Fix shareable_runtime and storybook

* ESLint Fixes

* Fix jest test and paths
# Conflicts:
#	.github/CODEOWNERS
#	test/scripts/jenkins_xpack.sh
#	x-pack/legacy/plugins/canvas/index.js
#	x-pack/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 6, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-actions
687607e 
* master: (72 commits)
  add tsvb tests to Firefox suite (elastic#65425)
  Fix flaky ServerMetricsCollector integration test (elastic#65420)
  [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428)
  [ML] Adds docs_per_second to transform edit form. (elastic#65365)
  update apm index pattern (elastic#65424)
  add direct build command (elastic#65431)
  [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417)
  [chore] Improve request cancelation handling in vis embeddable (elastic#65057)
  [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888)
  [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290)
  Additional branding updates (elastic#64712)
  Remove redundant formatting of percentage column (elastic#64948)
  [SIEM][CASE] Configuration pages UI redesign (elastic#65355)
  New nav (elastic#64018)
  [Ingest pipelines] Address copy feedback (elastic#65175)
  bug fixing (elastic#65387)
  skip whole suite blocking snapshots (elastic#65377)
  add related event generation to ancestor nodes (fixes a bug) (elastic#64950)
  [Canvas] move files from legacy/plugins to plugins (elastic#65283)
  [SIEM] template timeline UI (elastic#64439)
  ...
crob611 pushed a commit that referenced this pull request May 6, 2020
[7.x] [Canvas] move files from legacy/plugins to plugins (#65283) (#6…
f2cb92c 
…5406)

* [Canvas] move files from legacy/plugins to plugins (#65283)

* Moves the files

* Rename legacy/plugins/canvas paths

* Correct paths

* Fix shareable_runtime and storybook

* ESLint Fixes

* Fix jest test and paths
# Conflicts:
#	.github/CODEOWNERS
#	test/scripts/jenkins_xpack.sh
#	x-pack/legacy/plugins/canvas/index.js
#	x-pack/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts

* Remove CODEOWNERS that was added by merge conflict

* Removes some files that were hanging around in legacy/plugins/canvas
crob611 pushed a commit to crob611/kibana that referenced this pull request May 7, 2020
[7.x] [Canvas] move files from legacy/plugins to plugins (elastic#65283…
c2af1bf 
…) (elastic#65406)

* [Canvas] move files from legacy/plugins to plugins (elastic#65283)

* Moves the files

* Rename legacy/plugins/canvas paths

* Correct paths

* Fix shareable_runtime and storybook

* ESLint Fixes

* Fix jest test and paths
# Conflicts:
#	.github/CODEOWNERS
#	test/scripts/jenkins_xpack.sh
#	x-pack/legacy/plugins/canvas/index.js
#	x-pack/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts

* Remove CODEOWNERS that was added by merge conflict

* Removes some files that were hanging around in legacy/plugins/canvas
@crob611 crob611 mentioned this pull request May 7, 2020
Merged
7 tasks
crob611 pushed a commit that referenced this pull request May 8, 2020
@elasticmachine
[7.x] [Canvas] move files from legacy/plugins to plugins (#65283) (#6…
9d69d5d 
…5406) (#65769)

* [Canvas] move files from legacy/plugins to plugins (#65283)

* Moves the files

* Rename legacy/plugins/canvas paths

* Correct paths

* Fix shareable_runtime and storybook

* ESLint Fixes

* Fix jest test and paths
# Conflicts:
#	.github/CODEOWNERS
#	test/scripts/jenkins_xpack.sh
#	x-pack/legacy/plugins/canvas/index.js
#	x-pack/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts

* Remove CODEOWNERS that was added by merge conflict

* Removes some files that were hanging around in legacy/plugins/canvas

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@rylnd rylnd rylnd approved these changes

@cqliu1 cqliu1 cqliu1 approved these changes

@jbudz jbudz jbudz approved these changes

+1 more reviewer

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:NP Migration loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@crob611 @elasticmachine @spong @kibanamachine @ryankeairns @rylnd @poffdeluxe @cqliu1 @jbudz