[Lens] [7.7] Migration for 7.7#62877
Merged
wylieconlon merged 2 commits intoelastic:7.7from Apr 8, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Contributor
|
I've tested the following configurations on Chrome, migrating from 7.6:
All works as expected migrating from 7.6 to this PR. 👏 |
mbondyra
approved these changes
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a saved XY Lens visualization that was created pre-7.7, such as bar chart, line chart, or area chart, the configuration panel on the right would show empty dimensions like this:
The bug was caused by a change to how dimensions are represented that I introduced in #58279
Instead of fixing the bug in the runtime, this is fixing the bug using a migration. After 7.7 was branched from master, @timroes changed the way Lens saved objects were registered, so this PR can only target 7.7- another PR will target 7.8 and later
Fixes #61939
Replaces #62707
Checklist