Move Lens saved object setup to Kibana platform#61157
Merged
timroes merged 1 commit intoelastic:masterfrom Mar 25, 2020
Merged
Conversation
timroes
changed the title
timroes
commented
Mar 24, 2020
| getTitle: (obj: { attributes: { title: string } }) => obj.attributes.title, | ||
| getInAppUrl: (obj: { id: string }) => ({ | ||
| path: getEditPath(obj.id), | ||
| uiCapabilitiesPath: 'visualize.show', |
Contributor
Author
There was a problem hiding this comment.
ℹ️ We used before this move lens.show here, which was wrong, since there is no lens.show uiCapabilities. We decided that time to use the visualize uiCapability for Lens, it seemed just this place always returned the wrong capability.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
timroes
added
Feature:Lens
Feature:New Platform
release_note:skip
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
6 tasks
flash1293
approved these changes
Mar 25, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested and works, LGTM
wylieconlon
approved these changes
Mar 25, 2020
Contributor
wylieconlon
left a comment
wylieconlon
left a comment
There was a problem hiding this comment.
Haven't tested, but this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the Lens saved object registration from the legacy world to Kibana platform.
For QA: The only functional change this introduces is that Lens Saved Objects (in Management > Saved Objects) will now have an icon and can be clicked to view them in Lens.
Checklist
Delete any items that are not applicable to this PR.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibility[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser[ ] This was checked for cross-browser compatibility, including a check against IE11For maintainers
[ ] This was checked for breaking API changes and was labeled appropriately