[Lens] Fix empty dimensions after upgrading from pre-7.7#62707
Closed
wylieconlon wants to merge 1 commit intoelastic:masterfrom
Closed
[Lens] Fix empty dimensions after upgrading from pre-7.7#62707wylieconlon wants to merge 1 commit intoelastic:masterfrom
wylieconlon wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/lens/public/xy_visualization.xy_visualization #initialize removes dimensions from saved state if they are not on datasourceStandard OutStack TraceKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/lens/public/xy_visualization.xy_visualization #initialize keeps dimensions from saved state if they are in datasourceStandard OutStack TraceTo update your PR or re-run it, just comment with: |
Contributor
Author
|
Will look at doing this in a migration instead |
1 task
Contributor
Author
|
Using migration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a saved XY Lens visualization that was created pre-7.7, such as bar chart, line chart, or area chart, the configuration panel on the right would show empty dimensions like this:
The bug was caused by a change to how dimensions are represented that I introduced in #58279
The way I fixed this bug was by calling the
initializefunction when visualizations are loaded form a saved state, until the visualization returns an equal state.Fixes #61939
Checklist