Add Data - Adding cloud reset password link to cloud instructions by kobelb · Pull Request #62835 · elastic/kibana

kobelb · 2020-04-07T17:39:33Z

Changing the add data instructions to include a link allowing users to reset the password for their elastic user.

Before

After

This will only be shown when the xpack.cloud.resetPasswordUrl is set to a string. If xpack.cloud.resetPasswordUrl is not set to a string, it will revert to the prior behavior.

kobelb · 2020-04-07T18:18:23Z

@VijayDoshi @gchaps any feedback on the text?

@andrew-moldovan in https://github.com/elastic/cloud/issues/54532 you mentioned an approach for Cloud to generate the url for a reset password link which would be shown in the login assistance. Can we use this same approach to set xpack.cloud.resetPasswordUrl starting in 7.7 for ESS?

andrew-moldovan · 2020-04-07T18:23:38Z

Yes there shouldn't be any difference

kobelb · 2020-04-07T18:41:32Z

@elasticmachine merge upstream

gchaps · 2020-04-07T19:54:03Z

How about this text:

Forgot your password? Reset in Cloud console.

where " Reset in Cloud console" is the link.

@andrew-moldovan is "Cloud console" the correct term?

andrew-moldovan · 2020-04-07T20:19:36Z

@gchaps to close the loop (since we talked about this in Slack), we should probably use Elastic Cloud UI

gchaps · 2020-04-07T20:26:58Z

So then:

Forgot your password? Reset in Elastic Cloud UI.

kobelb · 2020-04-07T20:28:57Z

Thanks @gchaps and @andrew-moldovan! Charges forthcoming.

flash1293

Tested in Chrome and the new link is shown in the right scenarios - LGTM. It's great a PR adding new functionality is removing three times as many lines as it adds 👍

jowiho · 2020-04-08T13:46:37Z

Nit: should it be "Forgot the password?" instead of "Forgot your password?" because just before we say "the password of the elastic user"?

kobelb · 2020-04-08T13:51:00Z

@jowiho I deferred the decision on the text to Gail, who is our technical writer. I'd like to stick with her decision.

gchaps · 2020-04-08T13:51:55Z

@jowiho is correct. It should be "Forgot the password?"

kobelb · 2020-04-08T13:52:40Z

@jowiho is correct. It should be "Forgot the password."

Changes coming :)

…password

jowiho · 2020-04-08T13:56:42Z

@andrew-moldovan Is the name "Elastic Cloud UI" also suitable in other environments like ESSP or GovCloud?

alexfrancoeur · 2020-04-08T13:58:38Z

To be consistent with other areas of Kibana that reference Elastic Cloud, I'd opt for removing UI from the text. If we're not using Elastic Cloud console, I don't think we necessarily need to reference the UI bit, it feels unnecessary. Being even more specific, we could say Reset the password for your Elastic Cloud deployment.

And if for some reason we really feel like we need to keep the UI reference, we'd need to consider updating the Elastic Cloud tutorial templates to be consistent.

kobelb · 2020-04-08T14:11:44Z

To be consistent with other areas of Kibana that reference Elastic Cloud, I'd opt for removing UI from the text. If we're not using Elastic Cloud console, I don't think we necessarily need to reference the UI bit, it feels unnecessary

Good point. This change has been made.

kibanamachine · 2020-04-08T16:19:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a75f68b

History

💚 Build #39436 succeeded 4e125e0
💔 Build #39401 failed 3ba7978
💔 Build #39376 failed 5126bd8
💔 Build #39365 failed 51e76f4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…astic#62835) * Adding cloud reset password link to cloud filebeat instructions * Auditbeat gets the cool reset password link * And the other beats instructions get the awesome password reset link * Changing the i18n id to more closely match the on-prem cloud id * Changing text for forgot password * Removing now unused translations * "Forgot your password" -> "Forgot the password" * "Elastic Cloud UI" -> "Elastic Cloud" Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: [EPM] Update UI copy to use `integration` (elastic#63077) [NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (elastic#61575) [Maps] create NOT EXISTS filter for tooltip property with no value (elastic#62849) [Endpoint] Add link to Logs UI to the Host Details view (elastic#62852) [UI COPY] Fixes typo in max_shingle_size for search_as_you_type (elastic#63071) [APM] docs: add alerting examples for APM (elastic#62864) [EPM] Change PACKAGES_SAVED_OBJECT_TYPE id (elastic#62818) docs: fix rendering of bulleted list (elastic#62855) Exposed AddMessageVariables as separate component (elastic#63007) Add Data - Adding cloud reset password link to cloud instructions (elastic#62835) [ML] DF Analytics: update memory estimate after adding exclude fields (elastic#62850) [Table Vis] Fix visualization overflow (elastic#62630) [Endpoint][EPM] Endpoint depending on ingest manager to initialize (elastic#62871) [Remote clusters] Fix flaky jest tests (elastic#58768) [Discover] Hide time picker when an indexpattern without timefield is selected (elastic#62134) Move search source parsing and serializing to data (elastic#59919) [ML] Functional tests - stabilize typing in mml input (elastic#63091) [data.search.aggs]: Clean up TimeBuckets implementation (elastic#62123) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx

…2835) (#63126) * Adding cloud reset password link to cloud filebeat instructions * Auditbeat gets the cool reset password link * And the other beats instructions get the awesome password reset link * Changing the i18n id to more closely match the on-prem cloud id * Changing text for forgot password * Removing now unused translations * "Forgot your password" -> "Forgot the password" * "Elastic Cloud UI" -> "Elastic Cloud" Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…2835) (#63127) * Adding cloud reset password link to cloud filebeat instructions * Auditbeat gets the cool reset password link * And the other beats instructions get the awesome password reset link * Changing the i18n id to more closely match the on-prem cloud id * Changing text for forgot password * Removing now unused translations * "Forgot your password" -> "Forgot the password" * "Elastic Cloud UI" -> "Elastic Cloud" Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Adding cloud reset password link to cloud filebeat instructions

51e76f4

kobelb added Feature:Add Data Add Data and sample data feature on Home v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Apr 7, 2020

kobelb added 3 commits April 7, 2020 10:45

Auditbeat gets the cool reset password link

2e119d2

And the other beats instructions get the awesome password reset link

77da073

Changing the i18n id to more closely match the on-prem cloud id

5126bd8

Merge branch 'master' into home/cloud-reset-password

3ba7978

kobelb added 2 commits April 7, 2020 13:30

Changing text for forgot password

dc7941f

Removing now unused translations

4e125e0

kobelb marked this pull request as ready for review April 7, 2020 23:35

kobelb requested a review from flash1293 April 7, 2020 23:35

flash1293 approved these changes Apr 8, 2020

View reviewed changes

kobelb added 2 commits April 8, 2020 06:53

"Forgot your password" -> "Forgot the password"

f2761c8

Merge remote-tracking branch 'upstream/master' into home/cloud-reset-…

ac704ae

…password

"Elastic Cloud UI" -> "Elastic Cloud"

a75f68b

kobelb merged commit 90d2b18 into elastic:master Apr 9, 2020

kobelb deleted the home/cloud-reset-password branch April 9, 2020 14:43

This was referenced Apr 9, 2020

[7.x] Add Data - Adding cloud reset password link to cloud instructions (#62835) #63126

Merged

[7.7] Add Data - Adding cloud reset password link to cloud instructions (#62835) #63127

Merged

Conversation

kobelb commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

kobelb commented Apr 7, 2020

Uh oh!

andrew-moldovan commented Apr 7, 2020

Uh oh!

kobelb commented Apr 7, 2020

Uh oh!

gchaps commented Apr 7, 2020

Uh oh!

andrew-moldovan commented Apr 7, 2020

Uh oh!

gchaps commented Apr 7, 2020

Uh oh!

kobelb commented Apr 7, 2020

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

jowiho commented Apr 8, 2020

Uh oh!

kobelb commented Apr 8, 2020

Uh oh!

gchaps commented Apr 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kobelb commented Apr 8, 2020

Uh oh!

jowiho commented Apr 8, 2020

Uh oh!

alexfrancoeur commented Apr 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kobelb commented Apr 8, 2020

Uh oh!

kibanamachine commented Apr 8, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kobelb commented Apr 7, 2020 •

edited

Loading

gchaps commented Apr 8, 2020 •

edited

Loading

alexfrancoeur commented Apr 8, 2020 •

edited

Loading