[Discover] Hide time picker when an indexpattern without timefield is selected#62134
Merged
kertal merged 13 commits intoelastic:masterfrom Apr 9, 2020
Conversation
kertal
added
Feature:Discover
flash1293
approved these changes
Apr 2, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and works, LGTM 👍
Couldn't find enableTimeRangeSelector anywhere else in the discover code, is this a leftover of the migration?
Also, while testing for this PR I noticed that the error handling is broken when the last used index pattern doesn't exist (unrelated to this PR) - will create a separate issue for that.
Member
Author
|
@flash1293 yes, seems to be a leftover, I've added a functional test for that |
flash1293
reviewed
Apr 2, 2020
| await esArchiver.unload('index_pattern_without_timefield'); | ||
| }); | ||
|
|
||
| it('should not display a timepicker', async function() { |
Contributor
There was a problem hiding this comment.
nit: When we have this test we should only check whether it's shown correctly when there is a timefield
Member
Author
There was a problem hiding this comment.
you mean: we should also check if it's displayed correctly when there is a timefield, right?
Member
Author
There was a problem hiding this comment.
implemented this test, and finally Jenkins is green :)
…-01-fix-discover-index-pattern-without-timefield
…ttern-without-timefield
Member
Author
|
@elasticmachine merge upstream |
…ttern-without-timefield
Member
Author
|
@elasticmachine merge upstream |
…ttern-without-timefield
Member
Author
|
@elasticmachine merge upstream |
…ttern-without-timefield
Member
Author
|
@elasticmachine merge upstream |
…ttern-without-timefield
…-timefield' of github.com:kertal/kibana into kertal-pr-2020-04-01-fix-discover-index-pattern-without-timefield
Member
Author
|
@elasticmachine merge upstream |
…ttern-without-timefield
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Apr 9, 2020
… selected (elastic#62134) * Assign valid value whether the timepicker should be displayed * Add functional tests
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Apr 9, 2020
… selected (elastic#62134) * Assign valid value whether the timepicker should be displayed * Add functional tests
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 9, 2020
…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: [EPM] Update UI copy to use `integration` (elastic#63077) [NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (elastic#61575) [Maps] create NOT EXISTS filter for tooltip property with no value (elastic#62849) [Endpoint] Add link to Logs UI to the Host Details view (elastic#62852) [UI COPY] Fixes typo in max_shingle_size for search_as_you_type (elastic#63071) [APM] docs: add alerting examples for APM (elastic#62864) [EPM] Change PACKAGES_SAVED_OBJECT_TYPE id (elastic#62818) docs: fix rendering of bulleted list (elastic#62855) Exposed AddMessageVariables as separate component (elastic#63007) Add Data - Adding cloud reset password link to cloud instructions (elastic#62835) [ML] DF Analytics: update memory estimate after adding exclude fields (elastic#62850) [Table Vis] Fix visualization overflow (elastic#62630) [Endpoint][EPM] Endpoint depending on ingest manager to initialize (elastic#62871) [Remote clusters] Fix flaky jest tests (elastic#58768) [Discover] Hide time picker when an indexpattern without timefield is selected (elastic#62134) Move search source parsing and serializing to data (elastic#59919) [ML] Functional tests - stabilize typing in mml input (elastic#63091) [data.search.aggs]: Clean up TimeBuckets implementation (elastic#62123) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After selecting an indexpattern without timefield, the timepicker shouldn't be displayed. This PR implements this expected behavior
Fixes: #62417
Checklist