[Remote clusters] Fix flaky jest tests by alisonelizabeth · Pull Request #58768 · elastic/kibana

alisonelizabeth · 2020-02-27T19:41:35Z

Fixes #57762
Fixes #57997
Fixes #57998

elasticmachine · 2020-02-27T19:41:37Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

This reverts commit 44705fa.

…rs/flaky_tests

alisonelizabeth · 2020-03-25T21:49:24Z

retest

alisonelizabeth · 2020-03-26T00:04:09Z

retest

…rs/flaky_tests

alisonelizabeth · 2020-03-26T15:09:36Z

retest

alisonelizabeth · 2020-03-26T17:00:58Z

retest

alisonelizabeth · 2020-03-26T18:43:07Z

retest

alisonelizabeth · 2020-03-26T21:19:38Z

retest

alisonelizabeth · 2020-03-26T23:52:14Z

@elasticmachine merge upstream

…rs/flaky_tests

alisonelizabeth · 2020-04-03T20:32:40Z

@elasticmachine merge upstream

alisonelizabeth · 2020-04-03T22:22:07Z

retest

alisonelizabeth · 2020-04-04T00:37:21Z

retest

alisonelizabeth · 2020-04-04T16:37:11Z

@elasticmachine merge upstream

alisonelizabeth · 2020-04-05T00:59:48Z

retest

alisonelizabeth · 2020-04-05T17:46:14Z

retest

alisonelizabeth · 2020-04-07T00:54:32Z

@elasticmachine merge upstream

sebelga

LGTM! I left a few comments, none blockers.

x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_edit.test.js

sebelga · 2020-04-07T12:21:37Z

x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_edit.test.js

-    await nextTick();
-    addRemoteClusterComponent.update();
+    await act(async () => {
+      await nextTick();


Is it possible to also have a waitFor() here instead of the nextTick + component.update()?

Good point. Updated this to use waitFor().

sebelga · 2020-04-07T12:24:09Z

x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_list.test.js

@@ -241,8 +242,10 @@ describe('<RemoteClusterList />', () => {
        actions.clickBulkDeleteButton();


Not related to the changes in this PR but I am surprised that it does not complain to update the state outside an act() call for those 2 actions

I'm going to leave this as is for now, since it is unrelated to the current changes.

…rs/flaky_tests

alisonelizabeth · 2020-04-08T01:08:54Z

@elasticmachine merge upstream

alisonelizabeth · 2020-04-08T13:46:57Z

@elasticmachine merge upstream

alisonelizabeth · 2020-04-08T16:40:03Z

@elasticmachine merge upstream

alisonelizabeth · 2020-04-08T18:15:42Z

@elasticmachine merge upstream

alisonelizabeth · 2020-04-08T21:22:30Z

@elasticmachine merge upstream

kibanamachine · 2020-04-08T22:59:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a174ef6

History

💛 Build #39696 was flaky 7c670a4
💚 Build #39653 succeeded 58d4cc1
💔 Build #39576 failed b00755a
💚 Build #39496 succeeded 91cbee7
💚 Build #39450 succeeded a1f98a0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth · 2020-04-09T13:39:26Z

These tests have gone through CI successfully several times now, so I'm going to go ahead and merge. The latest failures were unrelated to the flakiness.

…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: [EPM] Update UI copy to use `integration` (elastic#63077) [NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (elastic#61575) [Maps] create NOT EXISTS filter for tooltip property with no value (elastic#62849) [Endpoint] Add link to Logs UI to the Host Details view (elastic#62852) [UI COPY] Fixes typo in max_shingle_size for search_as_you_type (elastic#63071) [APM] docs: add alerting examples for APM (elastic#62864) [EPM] Change PACKAGES_SAVED_OBJECT_TYPE id (elastic#62818) docs: fix rendering of bulleted list (elastic#62855) Exposed AddMessageVariables as separate component (elastic#63007) Add Data - Adding cloud reset password link to cloud instructions (elastic#62835) [ML] DF Analytics: update memory estimate after adding exclude fields (elastic#62850) [Table Vis] Fix visualization overflow (elastic#62630) [Endpoint][EPM] Endpoint depending on ingest manager to initialize (elastic#62871) [Remote clusters] Fix flaky jest tests (elastic#58768) [Discover] Hide time picker when an indexpattern without timefield is selected (elastic#62134) Move search source parsing and serializing to data (elastic#59919) [ML] Functional tests - stabilize typing in mml input (elastic#63091) [data.search.aggs]: Clean up TimeBuckets implementation (elastic#62123) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx

TEST commit: rerun flaky test suite 30 times

44705fa

alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 27, 2020

alisonelizabeth added 3 commits March 25, 2020 14:24

Revert "TEST commit: rerun flaky test suite 30 times"

d2bddee

This reverts commit 44705fa.

Merge branch 'master' of github.com:elastic/kibana into remote_cluste…

12fbaf2

…rs/flaky_tests

re-enable remote_cluster_edit jest tests

3692510

alisonelizabeth added 2 commits March 26, 2020 08:47

Merge branch 'master' of github.com:elastic/kibana into remote_cluste…

3cf9e00

…rs/flaky_tests

wrap component updates in act()

9be24be

elasticmachine and others added 4 commits March 26, 2020 19:52

Merge branch 'master' into remote_clusters/flaky_tests

25ac8e9

Merge branch 'master' of github.com:elastic/kibana into remote_cluste…

1324097

…rs/flaky_tests

add waitFor

7b1bc92

update jest test snapshot

b0394fe

Merge branch 'master' into remote_clusters/flaky_tests

d2fbe4c

Merge branch 'master' into remote_clusters/flaky_tests

59610c5

Merge branch 'master' into remote_clusters/flaky_tests

dc3de6f

Merge branch 'master' into remote_clusters/flaky_tests

016a2e1

sebelga approved these changes Apr 7, 2020

View reviewed changes

alisonelizabeth added 3 commits April 7, 2020 13:16

address feedback

2b11451

fix typo

bbd93e8

Merge branch 'master' of github.com:elastic/kibana into remote_cluste…

a1f98a0

…rs/flaky_tests

Merge branch 'master' into remote_clusters/flaky_tests

91cbee7

Merge branch 'master' into remote_clusters/flaky_tests

b00755a

Merge branch 'master' into remote_clusters/flaky_tests

58d4cc1

Merge branch 'master' into remote_clusters/flaky_tests

7c670a4

Merge branch 'master' into remote_clusters/flaky_tests

a174ef6

alisonelizabeth added v7.8.0 and removed v7.7.0 labels Apr 9, 2020

alisonelizabeth merged commit 883af70 into elastic:master Apr 9, 2020

alisonelizabeth deleted the remote_clusters/flaky_tests branch April 9, 2020 13:39

alisonelizabeth mentioned this pull request Apr 9, 2020

[7.x] [Remote clusters] Fix flaky jest tests (#58768) #63116

Merged

alisonelizabeth added a commit that referenced this pull request Apr 9, 2020

[7.x] [Remote clusters] Fix flaky jest tests (#58768) (#63116)

0cbf5e0

cjcenizal added the Feature:CCR and Remote Clusters label Nov 2, 2020

cjcenizal mentioned this pull request Nov 2, 2020

[Remote clusters] Reorganize test files #82362

Merged

		@@ -241,8 +242,10 @@ describe('<RemoteClusterList />', () => {
		actions.clickBulkDeleteButton();

Conversation

alisonelizabeth commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Feb 27, 2020

Uh oh!

alisonelizabeth commented Mar 25, 2020

Uh oh!

alisonelizabeth commented Mar 26, 2020

Uh oh!

alisonelizabeth commented Mar 26, 2020

Uh oh!

alisonelizabeth commented Mar 26, 2020

Uh oh!

alisonelizabeth commented Mar 26, 2020

Uh oh!

alisonelizabeth commented Mar 26, 2020

Uh oh!

alisonelizabeth commented Mar 26, 2020

Uh oh!

alisonelizabeth commented Apr 3, 2020

Uh oh!

alisonelizabeth commented Apr 3, 2020

Uh oh!

alisonelizabeth commented Apr 4, 2020

Uh oh!

alisonelizabeth commented Apr 4, 2020

Uh oh!

alisonelizabeth commented Apr 5, 2020

Uh oh!

alisonelizabeth commented Apr 5, 2020

Uh oh!

alisonelizabeth commented Apr 7, 2020

Uh oh!

sebelga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sebelga Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

sebelga Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth commented Apr 8, 2020

Uh oh!

alisonelizabeth commented Apr 8, 2020

Uh oh!

alisonelizabeth commented Apr 8, 2020

Uh oh!

alisonelizabeth commented Apr 8, 2020

Uh oh!

alisonelizabeth commented Apr 8, 2020

Uh oh!

kibanamachine commented Apr 8, 2020

💚 Build Succeeded

History

Uh oh!

alisonelizabeth commented Apr 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alisonelizabeth commented Feb 27, 2020 •

edited

Loading