Revert "Endpoint: Add ts-node dev dependency (#61884)"#62197
Merged
spalger merged 1 commit intoelastic:masterfrom Apr 1, 2020
Merged
Revert "Endpoint: Add ts-node dev dependency (#61884)"#62197spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
This reverts commit 4899aaf.
oatkiller
added
release_note:skip
kqualters-elastic
approved these changes
Apr 1, 2020
jonathan-buttner
approved these changes
Apr 1, 2020
alexk307
approved these changes
Apr 1, 2020
kevinlog
approved these changes
Apr 1, 2020
paul-tavares
approved these changes
Apr 1, 2020
marshallmain
approved these changes
Apr 1, 2020
tylersmalley
approved these changes
Apr 1, 2020
Member
tylersmalley
left a comment
tylersmalley
left a comment
There was a problem hiding this comment.
Adding another review for good measure
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 2, 2020
* master: [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186) [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931) ci: remove AppArch label from ProBot path-labeler (elastic#62211) [Uptime] Optimize get latest monitor API (elastic#61820) [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870) Remove polling delay (elastic#62099) accessibility tests for dashboard panel ( OSS) (elastic#62055) rename README.md to readme, avoiding issues with case change [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039) [SIEM] CASES Bugs BC2 (elastic#62170) Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197) Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111) [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094) [Maps] Update ems client dependency to 7.8.0 (elastic#62181) [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061) Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045) Update ILM node attributes blacklist. (elastic#62093)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4899aaf.
Summary
Adding
ts-nodecaused build issues. The original commit was low value and this should not disrupt our workflow at all. @spalger has ideas on how we can achieve the effect (not needing to globally installts-node) without causing issues. Will follow up w/ that in another issue/PRFor maintainers