[SIEM] [Detection Engine] Fixes all rules sorting#62039
Merged
dhurley14 merged 2 commits intoelastic:masterfrom Apr 1, 2020
Merged
[SIEM] [Detection Engine] Fixes all rules sorting#62039dhurley14 merged 2 commits intoelastic:masterfrom
dhurley14 merged 2 commits intoelastic:masterfrom
Conversation
dhurley14
added
v8.0.0
release_note:skip
dhurley14
changed the title
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
…able column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render
dhurley14
force-pushed
the
fix-sortable-rules-table
branch
from
99d8cd3 to
d43b8dc
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
Thanks @yctercero and @XavierM for your debugging efforts! |
dhurley14
changed the title
spong
reviewed
Apr 1, 2020
Comment on lines
+69
to
+72
| // for future devs: eui basic table is not giving us a prop to set the value, so | ||
| // we are using the ref in setTimeout to reset on the next loop so that we | ||
| // do not get a warning telling us we are trying to update during a render | ||
| window.setTimeout(() => tableRef?.current?.changeSelection([]), 0); |
Member
There was a problem hiding this comment.
Thanks for helping out our future selves! 😅
spong
approved these changes
Apr 1, 2020
Member
spong
left a comment
spong
left a comment
There was a problem hiding this comment.
Checked out, tested locally and sorting is functioning as intended! Thanks for the fix and additional comments around why as well -- LGTM! 👍
dhurley14
added a commit
to dhurley14/kibana
that referenced
this pull request
Apr 1, 2020
* fixes sorting to what it was in 7.6.1 * removes sortable=true from non-sortable columns, fixes naming of sortable column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render
dhurley14
added a commit
to dhurley14/kibana
that referenced
this pull request
Apr 1, 2020
* fixes sorting to what it was in 7.6.1 * removes sortable=true from non-sortable columns, fixes naming of sortable column field from activate to enabled to match the field eui expects to sort on, fixes react render warning due to resetting tableRef's current field during a render
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 2, 2020
* master: [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186) [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931) ci: remove AppArch label from ProBot path-labeler (elastic#62211) [Uptime] Optimize get latest monitor API (elastic#61820) [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870) Remove polling delay (elastic#62099) accessibility tests for dashboard panel ( OSS) (elastic#62055) rename README.md to readme, avoiding issues with case change [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039) [SIEM] CASES Bugs BC2 (elastic#62170) Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197) Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111) [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094) [Maps] Update ems client dependency to 7.8.0 (elastic#62181) [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061) Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045) Update ILM node attributes blacklist. (elastic#62093)
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rule activity monitoring disabled sorting. This PR enables sorting to what it was in 7.6.1. Unfortunately, sorting broke in 7.6.1 and is still broken in 7.6.2.
Need to do further investigation at some point.d43b8dc fixes #61624 sorting back to 7.6.0 functionality.7.6.0 sorting:
7.6.1 / 7.6.2 sorting (sorts once, won't sort after first click):
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser- [ ] This was checked for cross-browser compatibility, including a check against IE11For maintainers