Skip to content

Update ILM node attributes blacklist.#62093

Merged
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:chore/ignore-transform-node-attr
Apr 1, 2020
Merged

Update ILM node attributes blacklist.#62093
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:chore/ignore-transform-node-attr

Conversation

@cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Apr 1, 2020

Changes

Testing

Start ES with a custom node attribute:

yarn es snapshot --license=trial -E node.attr.rack=r1

Create a new ILM policy and verify that this r1 node attribute is the only one available. transform.node should not be available.

image

- Remove testattr because this doesn't seem to be something used in production by ES.
- Add 'transform.node' (added via https://github.com/elastic/elasticsearch/pull/52712/files#diff-225cc2c1291b4c60a8c3412a619094e1R147).
@cjcenizal cjcenizal added chore Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Apr 1, 2020
@cjcenizal cjcenizal requested a review from jloleysens April 1, 2020 00:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjcenizal tested locally and works as advertised (following the PR description).

@cjcenizal cjcenizal merged commit 82e0fd9 into elastic:master Apr 1, 2020
@cjcenizal cjcenizal deleted the chore/ignore-transform-node-attr branch April 1, 2020 16:29
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Apr 1, 2020
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Apr 1, 2020
cjcenizal added a commit that referenced this pull request Apr 1, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
* master:
  [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186)
  [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931)
  ci: remove AppArch label from ProBot path-labeler (elastic#62211)
  [Uptime] Optimize get latest monitor API (elastic#61820)
  [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870)
  Remove polling delay (elastic#62099)
  accessibility tests for dashboard panel ( OSS)  (elastic#62055)
  rename README.md to readme, avoiding issues with case change
  [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039)
  [SIEM] CASES Bugs BC2 (elastic#62170)
  Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197)
  Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111)
  [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094)
  [Maps] Update ems client dependency to 7.8.0 (elastic#62181)
  [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061)
  Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045)
  Update ILM node attributes blacklist. (elastic#62093)
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 3, 2020
cjcenizal added a commit that referenced this pull request Apr 4, 2020
- Remove 'testattr' because this doesn't seem to be used in production by ES.
- Add 'transform.node' (added via https://github.com/elastic/elasticsearch/pull/52712/files#diff-225cc2c1291b4c60a8c3412a619094e1R147).

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.7.0 v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments