[License Management] NP migration by sebelga · Pull Request #60250 · elastic/kibana

sebelga · 2020-03-16T12:25:44Z

This PR migrates the License Management app to the new platform.

How to test

launch ES in trial mode yarn es snapshot --license trial
keep a clean copy to be able to retest quickly cp -aR .es/8.0.0 .es/8.0.0-clean
Launch Kibana
Navigate to the App
Click "Extend trial" and make sure we are directed to the correct URL to extend the trial
Go back to the app and click "Revert to Basic license". A modal should open. Click "Confirm"
The browser window should refresh, and once back on the app there should only be 2 options: "Update your license" and "Extend trial"
The "Cross cluster replication" app should not appear in the menu on the left
Click "Update your license" and drag & drop the platinum dev license
The browser window should refresh and you should see your active platinum license

Delete the license through the API. In a terminal window run curl -XDELETE -v http://elastic:changeme@localhost:9200/_license
Manually refresh the Kibana browser window. You should see the Basic license back

Stop Elasticsearch
Delete the instance rm -rf .es/8.0.0
Copy the clean instance cp -aR .es/8.0.0-clean .es/8.0.0/
Restart ES .es/8.0.0/bin/elasticsearch
Manually refresh the Kibana browser window. You should be back to the Trial license

elasticmachine · 2020-03-16T12:27:12Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cchaos

Can you also remove the import to the styling_constants in index.scss? When importing the SASS via the plugin JS, these are now automatically referenced.

jloleysens

@sebelga this work looks in great shape overall!

Had one question and one suggestion for a typo (on the code side). When testing I ran into a bug while following the steps to upload a (platinum) license:

Would you mind taking a look?

jloleysens · 2020-03-17T08:46:38Z

x-pack/plugins/license_management/__jest__/upload_license.test.tsx

+  docLinks: {},
+};
+
+const thunkServices = {


What is meant by thunkServices? When I think of thunk (lol) what comes to mind is: value -> () => value.

Ah nvm, I see now what was meant by thunkServices further down (where the store is set up)

x-pack/plugins/license_management/server/types.ts

Co-Authored-By: Jean-Louis Leysens <jloleysens@gmail.com>

sebelga · 2020-03-17T12:39:35Z

Thanks for the review @cchaos and @jloleysens !
I removed the import of constants in the .scss file.

Good catch JL, this came from the last change on the server route path that I made to use an API_BASE_PATH. It has been fixed it. Do you mind having another look? Thanks!

sebelga · 2020-03-17T12:40:19Z

@elasticmachine merge upstream

cchaos

Found a typo, but SASS LGTM

cchaos · 2020-03-17T14:33:33Z

x-pack/plugins/license_management/public/application/index.scss

-// EUI globals
-@import 'src/legacy/ui/public/styles/styling_constants';
-
 // License amnagement plugin styles


Suggested change

// License amnagement plugin styles

// License management plugin styles

jloleysens

Looks good after latest changes (did not test upload again)

sebelga · 2020-03-17T15:55:16Z

@elasticmachine merge upstream

…nse-management

sebelga · 2020-03-18T10:12:20Z

@elasticmachine merge upstream

kibanamachine · 2020-03-18T12:01:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 446c6c6

History

💚 Build #33850 succeeded 9e03738
💔 Build #33793 failed 0fe8cdf
💔 Build #33773 failed 328c4a2
💔 Build #33735 failed 70b6eaa
💔 Build #33730 failed 29e2c45

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) add data-test-subj where possible on SO management table (elastic#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406)

…nless * 'app/painless' of github.com:elastic/kibana: (64 commits) Fix filter scope in bool query (#60488) change index pattern id to be the same as index pattern title (#60436) [Endpoint] resolver v1 events (#59233) Branding fixes for dashboard, loader and space selector (#60073) skip flaky suite (#60535) [SIEM][Detection Engine] Fixes bug with timeline templates not working Fixed errors which are happening if switch between alert types (#60453) [EPM] Add mapping field types to index template generation v2 (#60266) [NP] Cutover ensureDefaultIndexPattern to kibana_utils (#59895) Closes #60265. Adds Beta badge to service map (#60482) [Visualize] Duplicated query filters in es request (#60106) [ML] Disable functional transform tests Fixes to service map single node banner (#60072) [Uptime] replace fetch with kibana http (#59881) Upgrade @types/node to match Node.js runtime (#60368) [License Management] NP migration (#60250) Fix create alert button from not showing in alerts list (#60444) [SIEM][Case] Update connector through flyout (#60307) add data-test-subj where possible on SO management table (#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (#60406) ...

* upstream/app/painless: (66 commits) Another i18n issue Fix i18n Fix filter scope in bool query (elastic#60488) change index pattern id to be the same as index pattern title (elastic#60436) [Endpoint] resolver v1 events (elastic#59233) Branding fixes for dashboard, loader and space selector (elastic#60073) skip flaky suite (elastic#60535) [SIEM][Detection Engine] Fixes bug with timeline templates not working Fixed errors which are happening if switch between alert types (elastic#60453) [EPM] Add mapping field types to index template generation v2 (elastic#60266) [NP] Cutover ensureDefaultIndexPattern to kibana_utils (elastic#59895) Closes elastic#60265. Adds Beta badge to service map (elastic#60482) [Visualize] Duplicated query filters in es request (elastic#60106) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368) [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) ...

…alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (33 commits) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368) [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) add data-test-subj where possible on SO management table (elastic#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406) [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) ...

sebelga requested a review from a team as a code owner March 16, 2020 12:25

sebelga requested a review from jloleysens March 16, 2020 12:26

sebelga added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.7.0 v8.0.0 labels Mar 16, 2020

sebelga and others added 6 commits March 16, 2020 13:28

Update server API route with correct dependencies

fb35a72

Move to the "plugins" folder

ea8218f

Fix unit tests

df09d6e

Remove plugin initialisation from legacy

32c0e77

Camelcase plugin ID + update i18nrc path

4ae20ac

Add missing first() pipe operator to read license$

1f118c1

sebelga force-pushed the np-migration/license-management branch from 761e9fa to 1f118c1 Compare March 16, 2020 12:28

sebelga added 2 commits March 16, 2020 13:39

Cleanup unnecessary hooks

e9a5516

Use API_BASE_PATH on server routes

b8ae767

cchaos reviewed Mar 16, 2020

View reviewed changes

jloleysens requested changes Mar 17, 2020

View reviewed changes

sebelga and others added 5 commits March 17, 2020 10:58

Update x-pack/plugins/license_management/server/types.ts

29e2c45

Co-Authored-By: Jean-Louis Leysens <jloleysens@gmail.com>

Fix route dependencies plugins import

70b6eaa

Remove EUI sass constants import

3c5f78d

Fix failing test

79c8833

Fix server API route

dbf05e6

elasticmachine and others added 2 commits March 17, 2020 08:40

Merge branch 'master' into np-migration/license-management

328c4a2

Fix TS issues

0fe8cdf

cchaos approved these changes Mar 17, 2020

View reviewed changes

jloleysens approved these changes Mar 17, 2020

View reviewed changes

elasticmachine and others added 3 commits March 17, 2020 11:55

Merge branch 'master' into np-migration/license-management

9e03738

Merge remote-tracking branch 'upstream/master' into np-migration/lice…

5152933

…nse-management

Fix typo

453e878

Merge branch 'master' into np-migration/license-management

446c6c6

sebelga merged commit 2a8a7d7 into elastic:master Mar 18, 2020

sebelga deleted the np-migration/license-management branch March 18, 2020 12:36

sebelga mentioned this pull request Mar 18, 2020

[7.x] [License Management] NP migration (#60250) #60531

Merged

sebelga added a commit that referenced this pull request Mar 18, 2020

[License Management] NP migration (#60250) (#60531)

1e83027

	// License amnagement plugin styles
	// License management plugin styles

Comments

Conversation

sebelga commented Mar 16, 2020

How to test

Uh oh!

elasticmachine commented Mar 16, 2020

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

jloleysens Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

jloleysens Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sebelga commented Mar 17, 2020

Uh oh!

sebelga commented Mar 17, 2020

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

sebelga commented Mar 17, 2020

Uh oh!

sebelga commented Mar 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Mar 18, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jloleysens Mar 17, 2020 •

edited

Loading

sebelga commented Mar 18, 2020 •

edited

Loading