Index Action - Moved index params fields to connector config by YulNaumenko · Pull Request #60349 · elastic/kibana

YulNaumenko · 2020-03-17T03:04:26Z

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-03-17T03:04:29Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…ion-type-ui-changes # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

mikecote

LGTM, just a few comments / questions.

x-pack/plugins/actions/server/builtin_action_types/es_index.ts

.../plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx

pmuellr

code LGTM

Loaded the PR to test, love being able to choose the index and time field via pickers! There's some kind of odd behavior when you try to edit the index, after having picked one (click the x to delete, but it doesn't go away), but we can fix that in a separate issue - not a blocker.

x-pack/plugins/actions/server/builtin_action_types/es_index.ts

x-pack/plugins/actions/server/builtin_action_types/es_index.test.ts

pmuellr · 2020-03-17T15:49:14Z

x-pack/plugins/actions/server/builtin_action_types/es_index.test.ts

-    // minimal params, index via config and param
-    config = { index: 'index-via-config' };
+    // minimal params
+    config = { index: 'index-value', executionTimeField: undefined, refresh: false };


minimal params would just be index, since executionTimeField is maybe, and refresh has a default value

…ion-type-ui-changes # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…#60349) * Moved index params fields to connector config * Fixed type check issue * Fixing functional tests * Fixed due to comments * Fixed functional tests * Fixed tests and type check

kibanamachine · 2020-03-18T03:08:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 1c07847

Test Failures

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running 'yarn test:karma' should exit 0

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/59226

Stack Trace

Error: Command failed with exit code 3: yarn test:karma
    at makeError (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/lib/error.js:56:11)
    at handlePromise (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/index.js:114:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

💚 Build #34036 succeeded 1c07847
💔 Build #33992 failed 00e8703
💔 Build #33884 failed eba4f70
💔 Build #33699 failed 8ab5781
💔 Build #33684 failed 6798c29

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) Update ingest management team handle (elastic#60457) [IM] Use EuiCodeBlock to render index mapping (elastic#60420) Add additional safeguards for data source wizard step 2 (elastic#60426) [kbn/pm] don't fail when plugins are outside repo (elastic#60164) upgrade react-use (elastic#60427) Remove link to old settings (elastic#60326) Update app arch CODEOWNERS items. (elastic#60396) [ML] Fixing custom urls to dashboards (elastic#60355) Update the ems-client dependency to 7.7.0 (elastic#59936)

…#60349) * Moved index params fields to connector config * Fixed type check issue * Fixing functional tests * Fixed due to comments * Fixed functional tests * Fixed tests and type check

…#60517) * Moved index params fields to connector config * Fixed type check issue * Fixing functional tests * Fixed due to comments * Fixed functional tests * Fixed tests and type check

…alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (33 commits) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368) [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) add data-test-subj where possible on SO management table (elastic#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406) [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) ...

Moved index params fields to connector config

5d33d2b

YulNaumenko requested a review from a team as a code owner March 17, 2020 03:04

YulNaumenko self-assigned this Mar 17, 2020

YulNaumenko added 3 commits March 16, 2020 20:05

Fixed type check issue

e8a39a3

Fixing functional tests

8ab5781

mikecote self-requested a review March 17, 2020 12:59

mikecote approved these changes Mar 17, 2020

View reviewed changes

pmuellr approved these changes Mar 17, 2020

View reviewed changes

YulNaumenko added 4 commits March 17, 2020 09:46

Fixed due to comments

eba4f70

Fixed functional tests

935d8e0

Fixed tests and type check

00e8703

YulNaumenko merged commit 2207e0a into elastic:master Mar 18, 2020

YulNaumenko mentioned this pull request Mar 18, 2020

[7.x] Index Action - Moved index params fields to connector config (#60349) #60464

Closed

YulNaumenko mentioned this pull request Mar 18, 2020

[7.x] Index Action - Moved index params fields to connector config (#60349) #60517

Merged

mikecote removed the release_note:skip Skip the PR/issue when compiling release notes label Apr 15, 2020

mikecote added release_note:breaking release_note:enhancement labels Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Index Action - Moved index params fields to connector config#60349

Index Action - Moved index params fields to connector config#60349
YulNaumenko merged 8 commits intoelastic:masterfrom
YulNaumenko:actions-index-action-type-ui-changes

YulNaumenko commented Mar 17, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

mikecote left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pmuellr left a comment

Uh oh!

Uh oh!

Uh oh!

pmuellr Mar 17, 2020

Uh oh!

kibanamachine commented Mar 18, 2020

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

YulNaumenko commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pmuellr Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 18, 2020

💔 Build Failed

Test Failures

Standard Out

Stack Trace

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

YulNaumenko commented Mar 17, 2020 •

edited

Loading