Branding fixes for dashboard, loader and space selector#60073
Merged
snide merged 9 commits intoelastic:masterfrom Mar 18, 2020
Merged
Branding fixes for dashboard, loader and space selector#60073snide merged 9 commits intoelastic:masterfrom
snide merged 9 commits intoelastic:masterfrom
Conversation
snide
added
release_note:skip
mshustov
approved these changes
Mar 13, 2020
Contributor
|
I 😍 this PR. Looks really great! I do have a couple concerns with the new exit full screen button. Don't get me wrong, I do really like the way it looks. So much classier. My worry is with it functionally.
|
Contributor
Author
That's a good point. I can also see about dropping the size down a bit. |
lizozom
approved these changes
Mar 15, 2020
Contributor
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Changes tested and working.
However, I do want to say that the new full screen exit button design, doesn't look like intuitive to me.
It looks more like a notification that needs to be dismissed.
Technically however, LGTM
Contributor
Author
|
@cchaos Went smaller. Flipped the colors so it would be noticible now that the surrounding whitespace doesn't key it out. Text and icon changed as well.
|
cchaos
approved these changes
Mar 18, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
The full screen button is more more obvious what it does now and users will be happier with the condensed size. 👍 🚀
Contributor
Author
|
jenkins test this |
Contributor
Author
|
Merging this one on green. |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
that referenced
this pull request
Mar 18, 2020
…nless * 'app/painless' of github.com:elastic/kibana: (64 commits) Fix filter scope in bool query (#60488) change index pattern id to be the same as index pattern title (#60436) [Endpoint] resolver v1 events (#59233) Branding fixes for dashboard, loader and space selector (#60073) skip flaky suite (#60535) [SIEM][Detection Engine] Fixes bug with timeline templates not working Fixed errors which are happening if switch between alert types (#60453) [EPM] Add mapping field types to index template generation v2 (#60266) [NP] Cutover ensureDefaultIndexPattern to kibana_utils (#59895) Closes #60265. Adds Beta badge to service map (#60482) [Visualize] Duplicated query filters in es request (#60106) [ML] Disable functional transform tests Fixes to service map single node banner (#60072) [Uptime] replace fetch with kibana http (#59881) Upgrade @types/node to match Node.js runtime (#60368) [License Management] NP migration (#60250) Fix create alert button from not showing in alerts list (#60444) [SIEM][Case] Update connector through flyout (#60307) add data-test-subj where possible on SO management table (#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (#60406) ...
snide
added a commit
that referenced
this pull request
Mar 19, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 19, 2020
* upstream/app/painless: (66 commits) Another i18n issue Fix i18n Fix filter scope in bool query (elastic#60488) change index pattern id to be the same as index pattern title (elastic#60436) [Endpoint] resolver v1 events (elastic#59233) Branding fixes for dashboard, loader and space selector (elastic#60073) skip flaky suite (elastic#60535) [SIEM][Detection Engine] Fixes bug with timeline templates not working Fixed errors which are happening if switch between alert types (elastic#60453) [EPM] Add mapping field types to index template generation v2 (elastic#60266) [NP] Cutover ensureDefaultIndexPattern to kibana_utils (elastic#59895) Closes elastic#60265. Adds Beta badge to service map (elastic#60482) [Visualize] Duplicated query filters in es request (elastic#60106) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368) [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59955
Some more cleanup for branding.
cc @alexfrancoeur @cchaos @ryankeairns
Fullscreen exit on dashboard
Correct colors in dark mode loader
Spaces screen now has correct logo