[kbn/pm] don't fail when plugins are outside repo#60164
Merged
spalger merged 5 commits intoelastic:masterfrom Mar 17, 2020
Merged
[kbn/pm] don't fail when plugins are outside repo#60164spalger merged 5 commits intoelastic:masterfrom
spalger merged 5 commits intoelastic:masterfrom
Conversation
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
brianseeders
approved these changes
Mar 17, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
| "globby": "^8.0.1", | ||
| "has-ansi": "^3.0.0", | ||
| "indent-string": "^3.2.0", | ||
| "is-path-inside": "^3.0.2", |
Member
There was a problem hiding this comment.
Is a dependency really necessary to test if a path starts with another path?
Contributor
Author
There was a problem hiding this comment.
Sorry, didn't see this before merge. It's not necessary but it covers some edge cases, is already installed (checkout the changes to yarn.lock) and isn't included in the front end so I didn't see any harm in it.
Contributor
Author
There was a problem hiding this comment.
It's also hyper focused so it would be really easy to rip out, and will be really easy to upgrade. It is the best kind of dependency if you ask me.
Member
There was a problem hiding this comment.
That's fair. Though looks like the only edge case is with 32bit Windows which we don't support.
This really should be part path or something in core utils.
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Mar 17, 2020
* [kbn/pm] don't fail when plugins are outside repo * remove unused import Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 18, 2020
* master: [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) Update ingest management team handle (elastic#60457) [IM] Use EuiCodeBlock to render index mapping (elastic#60420) Add additional safeguards for data source wizard step 2 (elastic#60426) [kbn/pm] don't fail when plugins are outside repo (elastic#60164) upgrade react-use (elastic#60427) Remove link to old settings (elastic#60326) Update app arch CODEOWNERS items. (elastic#60396) [ML] Fixing custom urls to dashboards (elastic#60355) Update the ems-client dependency to 7.7.0 (elastic#59936)
spalger
added a commit
that referenced
this pull request
Mar 18, 2020
* [kbn/pm] don't fail when plugins are outside repo * remove unused import Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
7.x/7.7: 719dbe7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59931 (comment)
When we added the bootstrap cache in #53622 we didn't verify that it continued to work when people have plugins that are outside of the repo (in kibana-extra directories for instance). These projects are still picked up by
@kbn/pm, and so they need to be handled properly by the bootstrap cache generation logic. Thankfully the logic already has conditions in place for when the cache key can't be generated for whatever reason, and this is just an extension of that which prevents passing paths to git which would cause it to fail.