[Maps] Add field and style-meta types #58766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint restrict to fieldmeta fix rename
thomasneirynck
added
chore
release_note:skip
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Feb 27, 2020
nreese
reviewed
Feb 27, 2020
nreese
reviewed
Feb 27, 2020
nreese
reviewed
Feb 27, 2020
nreese
reviewed
Feb 27, 2020
nreese
reviewed
Feb 27, 2020
nreese
reviewed
Feb 27, 2020
x-pack/legacy/plugins/maps/public/layers/styles/vector/style_meta.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
nreese
reviewed
Mar 4, 2020
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
nreese
reviewed
Mar 5, 2020
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_size_property.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.test.js
Outdated
Show resolved
Hide resolved
nreese
reviewed
Mar 5, 2020
...ck/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.test.js
Outdated
Show resolved
Hide resolved
nreese
approved these changes
Mar 5, 2020
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
LGTM with green CI
code review
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Mar 5, 2020
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
nreese
pushed a commit
that referenced
this pull request
Mar 7, 2020
Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
removed
the
backport missing
This was referenced Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57908 revealed the need to make style and field-meta more flexible. Fields need to accommodate multiple style-metas (e.g. ranges and term-counts).
Rather than clutter that PR with new
.tsboilerplate for the refactor, extracting some of those preliminaries here in a separate PR.