[Maps] Support categorical styling for numbers and dates by thomasneirynck · Pull Request #57908 · elastic/kibana

thomasneirynck · 2020-02-18T20:31:00Z

Introduces a few changes:

Adds quantitative/qualitative selector.

It adds number/date fields to the icon-selector.

It removes all the get[Number|Date|...]Field methods from Source and Layer, in favor of letting the vector-style-editor component filter out fields by type.

elasticmachine · 2020-02-18T20:31:03Z

Pinging @elastic/kibana-gis (Team:Geo)

thomasneirynck · 2020-02-20T16:44:05Z

Assigned review, wanting to get a sense if this is the right way to do it. Basically, just use the "type" field on the dynamic_style-property to toggle between categorical/qualitative.

~~Custom-palettes are not working yet. Still need to check what's going wrong there.~~

nreese · 2020-02-21T20:16:58Z

@elasticmachine merge upstream

nreese · 2020-02-21T20:35:57Z

I think this is a good approach.

Just a few comments. "Quantitative" and "Qualitative" are complex words for users without a strong math/data visualization background. I think we need some help text or tooltip to explain the difference between the two.

Should add number and date fields to icon style by value as well so numbers can be used for setting icon.

thomasneirynck · 2020-02-23T23:32:05Z

x-pack/legacy/plugins/maps/public/layers/styles/vector/components/color/color_map_select.js

+          'xpack.maps.styles.dynamicColorSelect.qualitativeOrQuantitativeTooltip',
+          {
+            defaultMessage:
+              'Choose `quantitative` to map the value as a number to a color on a range. Choose `qualitative` to map the value as a category to a color from a palette',


@gchaps I could probably use some help with some good help-text here 😃 Any ideas to make this read better?

Instead of a tooltip, how about EuiFormRow help text for the selected value?

Do either of these work?

Choose Quantitative to map the value to a number in a color range, or Qualitative to map to a category in a color palette.

Choose Quantitative to map by number in a color range, or Qualitative to categorize by color palette.

thx @gchaps !

to avoid some clutter in the UX (which is getting really long), we were thinking if we could avoid the help-text if the select-box uses "As number" and "As category" for the options. It'd still using your help-text in the aria-label.

That wording is much clearer than using quantitative and qualitative.

But should it be "By number" and "By category"?

@gchaps maybe (?) :) not super familiar with the nuances here.

It's basically to express the difference in how the value should be interpreted. Should the value be interpreted as a number on a range, then we can map it to a continuous color-range. Should the value be interpreted as a category, then we just assign a color-value.

I can make this change to 'by', but 'as' seems to fit a little better by what it's trying to express.

Got it. 'as' is the better choice.

nreese

Nice improvements. Really like removing of getDateFields, getNumberFields, and getCategoricalFields

x-pack/legacy/plugins/maps/public/layers/sources/es_geo_grid_source/es_geo_grid_source.d.ts

x-pack/legacy/plugins/maps/public/layers/sources/es_geo_grid_source/es_geo_grid_source.test.ts

x-pack/legacy/plugins/maps/public/layers/sources/es_term_source.test.js

x-pack/legacy/plugins/maps/public/layers/styles/vector/components/color/color_map_select.js

x-pack/legacy/plugins/maps/public/layers/styles/vector/components/vector_style_editor.js

...ck/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.test.js

x-pack/legacy/plugins/maps/public/layers/styles/vector/components/vector_style_editor.js

x-pack/legacy/plugins/maps/public/layers/sources/es_geo_grid_source/es_geo_grid_source.test.ts

x-pack/legacy/plugins/maps/common/constants.ts

x-pack/legacy/plugins/maps/public/layers/fields/top_term_percentage_field.ts

x-pack/legacy/plugins/maps/public/layers/styles/vector/components/color/color_map_select.js

...ck/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.test.js

nreese

lgtm with green ci
code review, tested in chrome

kibanamachine · 2020-03-09T17:21:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a66bb34

History

💔 Build #31781 failed 02c725e
💔 Build #31740 failed 9180698
💔 Build #31626 failed 3c4cd9b
💚 Build #31327 succeeded fee6793
💔 Build #31207 failed c6e2535

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…9684)

* master: (22 commits) Generate docs from data plugin (elastic#56955) Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514) Harden creation of child processes (elastic#55697) [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475) [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553) chore: 🤖 hide Drilldowns in master (elastic#59698) [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175) Use HTTP request schemas to create types, use those types in the client (elastic#59340) [Maps] Support categorical styling for numbers and dates (elastic#57908) [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665) Fix slm_ui setting by changing camel case back to snake case. (elastic#59663) removes beta tag (elastic#59618) [DOCS] Removed spatial references (elastic#59595) fix outdated docs (elastic#58729) [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639) [ML] Refactoring anomaly detector job types (elastic#59556) [Upgrade Assistant] Better handling of closed indices (elastic#58890) additional visualizations plugin cleanup before moving to NP (elastic#59318) In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285) [Visualize] Remove global state in visualize (elastic#58352) ...

…s/kibana into alerting/fix-flaky-instance-test * 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits) Generate docs from data plugin (elastic#56955) Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514) Harden creation of child processes (elastic#55697) [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475) [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553) chore: 🤖 hide Drilldowns in master (elastic#59698) [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175) Use HTTP request schemas to create types, use those types in the client (elastic#59340) [Maps] Support categorical styling for numbers and dates (elastic#57908) [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665) Fix slm_ui setting by changing camel case back to snake case. (elastic#59663) removes beta tag (elastic#59618) [DOCS] Removed spatial references (elastic#59595) fix outdated docs (elastic#58729) [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639) [ML] Refactoring anomaly detector job types (elastic#59556) [Upgrade Assistant] Better handling of closed indices (elastic#58890) additional visualizations plugin cleanup before moving to NP (elastic#59318) In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285) [Visualize] Remove global state in visualize (elastic#58352) ...

thomasneirynck added release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.7.0 labels Feb 18, 2020

elizabetdev self-requested a review February 19, 2020 12:15

thomasneirynck requested review from kindsun and nreese February 20, 2020 16:40

thomasneirynck marked this pull request as ready for review February 20, 2020 16:40

thomasneirynck requested a review from a team as a code owner February 20, 2020 16:40

thomasneirynck added the WIP Work in progress label Feb 20, 2020

elizabetdev mentioned this pull request Feb 20, 2020

Improving the color map select styles thomasneirynck/kibana#12

Merged

thomasneirynck force-pushed the number_ordinals branch from fed77c5 to 26607b4 Compare February 23, 2020 22:40

thomasneirynck and others added 10 commits February 23, 2020 17:46

boilerplate

f544734

styling

4be903f

fix

894a5ba

remove cruft

3f798be

Improving color map select styles

cc0738d

enable for icon-fields

67fa1b8

remove unused

09af833

only include styleable fields

42d7cd3

remove number fields

6cf2e34

remove date fields

42b1d88

thomasneirynck force-pushed the number_ordinals branch from 26607b4 to 42b1d88 Compare February 23, 2020 22:49

thomasneirynck added 2 commits February 23, 2020 18:29

add tooltip

f927b75

change text

567c36b

thomasneirynck commented Feb 23, 2020

View reviewed changes

thomasneirynck added 3 commits March 5, 2020 22:27

lint fix

b6764d8

fix name

cb0e37a

fix faulty merge

fee6793

nreese reviewed Mar 6, 2020

View reviewed changes

thomasneirynck added 2 commits March 6, 2020 16:35

init feedback

89d461d

more edits

fae5e84

nreese reviewed Mar 6, 2020

View reviewed changes

x-pack/legacy/plugins/maps/public/layers/styles/vector/components/vector_style_editor.js Outdated Show resolved Hide resolved

nreese reviewed Mar 6, 2020

View reviewed changes

x-pack/legacy/plugins/maps/public/layers/sources/es_geo_grid_source/es_geo_grid_source.test.ts Outdated Show resolved Hide resolved

thomasneirynck added 8 commits March 7, 2020 18:53

test

2958ba7

language

cc08409

add dummy test

3c4cd9b

Merge branch 'master' into maps/numbers_ordinals

9180698

remove agg type

6a3b99a

remove getAggType

7813255

add more boilerplate

1c7391d

remove cruft

02c725e

thomasneirynck requested a review from nreese March 9, 2020 15:05

nreese reviewed Mar 9, 2020

View reviewed changes

thomasneirynck added 3 commits March 9, 2020 11:20

remove aggtype

4756563

formatting

e7153db

remove from constants

a66bb34

nreese approved these changes Mar 9, 2020

View reviewed changes

thomasneirynck merged commit 6e5e8c8 into elastic:master Mar 9, 2020

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Mar 9, 2020

[Maps] Support categorical styling for numbers and dates (elastic#57908)

87c05d9

thomasneirynck mentioned this pull request Mar 9, 2020

[7.x] [Maps] Support categorical styling for numbers and dates (#57908) #59684

Merged

thomasneirynck added a commit that referenced this pull request Mar 9, 2020

[Maps] Support categorical styling for numbers and dates (#57908) (#5…

ea428cc

…9684)

Conversation

thomasneirynck commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Feb 18, 2020

Uh oh!

thomasneirynck commented Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Feb 21, 2020

Uh oh!

nreese commented Feb 21, 2020

Uh oh!

thomasneirynck Feb 23, 2020

Choose a reason for hiding this comment

Uh oh!

nreese Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

gchaps Feb 26, 2020

Choose a reason for hiding this comment

Uh oh!

thomasneirynck Feb 26, 2020

Choose a reason for hiding this comment

Uh oh!

gchaps Feb 26, 2020

Choose a reason for hiding this comment

Uh oh!

thomasneirynck Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

gchaps Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 9, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

thomasneirynck commented Feb 18, 2020 •

edited

Loading

thomasneirynck commented Feb 20, 2020 •

edited

Loading