[ML] Fixing missing job_type in job messages search #55330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson,
pheyos and
walterra
jgowdyelastic
added
:ml
bug
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pheyos
approved these changes
Jan 20, 2020
Member
pheyos
left a comment
pheyos
left a comment
There was a problem hiding this comment.
Tested locally and also copied the generated query over to the 7.6.0-bc1 cloud cluster where we've seen the job message issues after upgrading: Works fine.
LGTM
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jan 20, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* master: [ML] Fixing missing job_type in job messages search (elastic#55330) [ML] Correctly pass on severity value to anomaly explorer charts. (elastic#55207)
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jan 20, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Jan 20, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the audit message searches to match on job_type: 'anomaly_detector' or if job_type isn't present at all.
If job_type isn't present, this is a version of the .ml-notifications which predates the changes made in elastic/elasticsearch#45967
Removes unused job messages service.
This change was originally made in #45121, however that service was not being used.