Implement DataFrameAnalyticsAuditMessage and DataFrameAnalyticsAuditor#45967
Implement DataFrameAnalyticsAuditMessage and DataFrameAnalyticsAuditor#45967przemekwitek merged 5 commits intoelastic:masterfrom
Conversation
|
run elasticsearch-ci/default-distro |
|
Pinging @elastic/ml-core |
df1d3cd to
4c2b96f
Compare
|
run elasticsearch-ci/1 |
|
run elasticsearch-ci/2 |
1 similar comment
|
run elasticsearch-ci/2 |
6b5e56e to
1c94829
Compare
60bbc94 to
59b91dc
Compare
benwtrent
left a comment
There was a problem hiding this comment.
I think the only folks that read from this index is Kibana.
I hope that they use an index pattern to read. Do they already have code in flight to handle the situation where:
"job_type == null" => "anomaly detection"?
Just want to make sure that they are good to go with this change :).
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java
Outdated
Show resolved
Hide resolved
59b91dc to
71d55d5
Compare
Not yet, will coordinate with them before this PR is merged in. |
...rc/main/java/org/elasticsearch/xpack/core/ml/notifications/AnomalyDetectionAuditMessage.java
Outdated
Show resolved
Hide resolved
3438728 to
47690ae
Compare
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/bwc |
.../main/java/org/elasticsearch/xpack/core/ml/notifications/DataFrameAnalyticsAuditMessage.java
Outdated
Show resolved
Hide resolved
|
run elasticsearch-ci/bwc |
3e5f7c7 to
abd1546
Compare
|
run elasticsearch-ci/1 |
|
run elasticsearch-ci/bwc |
1 similar comment
|
run elasticsearch-ci/bwc |
Add jobType field to AbstractAuditMessage so that anomaly detection audit messges and data frame analytics audit messages can be told apart in the common index
abd1546 to
5939c0d
Compare
This PR implements new subclass of AbstractAuditor: DataFrameAnalyticsAuditor as well as a new subclass of AbstractAuditMessage: DataFrameAnalyticsAuditMessage.
It also:
Relates https://github.com/elastic/ml-team/issues/184