Skip to content

Implement DataFrameAnalyticsAuditMessage and DataFrameAnalyticsAuditor#45967

Merged
przemekwitek merged 5 commits intoelastic:masterfrom
przemekwitek:dfa_auditor
Sep 10, 2019
Merged

Implement DataFrameAnalyticsAuditMessage and DataFrameAnalyticsAuditor#45967
przemekwitek merged 5 commits intoelastic:masterfrom
przemekwitek:dfa_auditor

Conversation

@przemekwitek
Copy link

@przemekwitek przemekwitek commented Aug 26, 2019

This PR implements new subclass of AbstractAuditor: DataFrameAnalyticsAuditor as well as a new subclass of AbstractAuditMessage: DataFrameAnalyticsAuditMessage.
It also:

  • adds jobType field to AbstractAuditMessage so that anomaly detection audit messages and data frame analytics audit messages can be told apart in the common index (".ml-notifications")
  • adds the new index template (".ml-notifications-000001") with the new field ("job_type") and "dynamic" setting set to "false"

Relates https://github.com/elastic/ml-team/issues/184

@przemekwitek
Copy link
Author

run elasticsearch-ci/default-distro

@davidkyle davidkyle added the :ml Machine learning label Aug 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@przemekwitek
Copy link
Author

run elasticsearch-ci/1

@przemekwitek
Copy link
Author

run elasticsearch-ci/2

1 similar comment
@przemekwitek
Copy link
Author

run elasticsearch-ci/2

@przemekwitek przemekwitek force-pushed the dfa_auditor branch 2 times, most recently from 6b5e56e to 1c94829 Compare August 29, 2019 10:57
@przemekwitek przemekwitek removed the WIP label Aug 29, 2019
@przemekwitek przemekwitek marked this pull request as ready for review August 29, 2019 11:00
@przemekwitek przemekwitek added v7.5.0 :ml Machine learning and removed v7.4.0 :ml Machine learning labels Aug 29, 2019
@benwtrent benwtrent self-requested a review August 29, 2019 12:02
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only folks that read from this index is Kibana.

I hope that they use an index pattern to read. Do they already have code in flight to handle the situation where:

"job_type == null" => "anomaly detection"?

Just want to make sure that they are good to go with this change :).

@przemekwitek
Copy link
Author

I think the only folks that read from this index is Kibana.

I hope that they use an index pattern to read. Do they already have code in flight to handle the situation where:

"job_type == null" => "anomaly detection"?

Just want to make sure that they are good to go with this change :).

Not yet, will coordinate with them before this PR is merged in.

@przemekwitek
Copy link
Author

run elasticsearch-ci/bwc

@przemekwitek
Copy link
Author

run elasticsearch-ci/bwc

@przemekwitek
Copy link
Author

run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

@przemekwitek
Copy link
Author

run elasticsearch-ci/1

@przemekwitek
Copy link
Author

run elasticsearch-ci/bwc

1 similar comment
@przemekwitek
Copy link
Author

run elasticsearch-ci/bwc

Przemyslaw Witek added 5 commits September 9, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants