[ML] Anomaly Explorer: Correctly pass on severity value to anomaly explorer charts. #55207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
walterra
requested review from
alvarezmelissa87,
darnautov,
jgowdyelastic and
peteharverson
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Jan 20, 2020
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and confirm anomaly markers are now displaying correctly. LGTM.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jan 20, 2020
…astic#55207) - Fixes passing on the severity value correctly to anomaly explorer charts. The wrong value of undefined being passed down caused anomaly markers not showing up. - This bug surfaced that the severity value was never applied to filter multi-bucket anomalies which is now also fixed by this PR. - Adds a check if topInfluencers is an array.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jan 20, 2020
…astic#55207) - Fixes passing on the severity value correctly to anomaly explorer charts. The wrong value of undefined being passed down caused anomaly markers not showing up. - This bug surfaced that the severity value was never applied to filter multi-bucket anomalies which is now also fixed by this PR. - Adds a check if topInfluencers is an array.
This was referenced Jan 20, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* upstream/master: [ML] Correctly pass on severity value to anomaly explorer charts. (elastic#55207)
walterra
added a commit
that referenced
this pull request
Jan 20, 2020
…5207) (#55329) - Fixes passing on the severity value correctly to anomaly explorer charts. The wrong value of undefined being passed down caused anomaly markers not showing up. - This bug surfaced that the severity value was never applied to filter multi-bucket anomalies which is now also fixed by this PR. - Adds a check if topInfluencers is an array.
walterra
added a commit
that referenced
this pull request
Jan 20, 2020
…5207) (#55328) - Fixes passing on the severity value correctly to anomaly explorer charts. The wrong value of undefined being passed down caused anomaly markers not showing up. - This bug surfaced that the severity value was never applied to filter multi-bucket anomalies which is now also fixed by this PR. - Adds a check if topInfluencers is an array.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* master: [ML] Fixing missing job_type in job messages search (elastic#55330) [ML] Correctly pass on severity value to anomaly explorer charts. (elastic#55207)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regression introduced in #52987.
Part of #52986.
severityvalue correctly to anomaly explorer charts. The wrong value ofundefinedbeing passed down caused anomaly markers not showing up.severityvalue was never applied to filter multi-bucket anomalies which is now also fixed by this PR.topInfluencersis anarray.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers