Skip to content

[Logs + Metrics UI] Use getTraceURL for APM trace links#52875

Merged
afgomez merged 4 commits into
elastic:masterfrom
afgomez:52198-apm-trace-link
Dec 16, 2019
Merged

[Logs + Metrics UI] Use getTraceURL for APM trace links#52875
afgomez merged 4 commits into
elastic:masterfrom
afgomez:52198-apm-trace-link

Conversation

@afgomez
Copy link
Copy Markdown
Contributor

@afgomez afgomez commented Dec 12, 2019

Replace the hardcoded URL with a helper function provided by the APM team.

Closes #52198

@afgomez afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Dec 12, 2019
@afgomez afgomez requested a review from a team as a code owner December 12, 2019 13:26
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 12, 2019

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

weltenwort
weltenwort reviewed Dec 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Reviewing on behalf of @elastic/logs-metrics-ui...

weltenwort
weltenwort approved these changes Dec 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one question below

Comment thread ...acy/plugins/infra/public/components/logging/log_entry_flyout/log_entry_actions_menu.test.tsx Outdated
Alejandro Fernández Gómez added 2 commits December 16, 2019 14:33
Merge branch 'master' into 52198-apm-trace-link
f48d7b7
Check for the presence of APM links
fe720aa 
Since now we use a helper provided by APM it no longer makes sense to
test for the actual URL (because that only tests the function). Instead
just test that the link exists and that it has an `href`.
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2019

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 3137b07 into elastic:master Dec 16, 2019
@afgomez afgomez deleted the 52198-apm-trace-link branch December 16, 2019 16:00
@afgomez afgomez mentioned this pull request Dec 16, 2019
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Dec 16, 2019
[Logs + Metrics UI] Use getTraceURL for APM trace links (elastic#52875
c7dd472 
)

* Use `getTraceURL` for APM trace links

* Fix tests

* Check for the presence of APM links

Since now we use a helper provided by APM it no longer makes sense to
test for the actual URL (because that only tests the function). Instead
just test that the link exists and that it has an `href`.
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
[Logs + Metrics UI] Use getTraceURL for APM trace links (elastic#52875
c0613fc 
)

* Use `getTraceURL` for APM trace links

* Fix tests

* Check for the presence of APM links

Since now we use a helper provided by APM it no longer makes sense to
test for the actual URL (because that only tests the function). Instead
just test that the link exists and that it has an `href`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees

No one assigned

Labels

Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Logs & Metrics UI] Link directly to APM trace instead of traces page + filter query param

3 participants

@afgomez @elasticmachine @weltenwort