Skip to content

[7.x] [Logs + Metrics UI] Use getTraceURL for APM trace links (#52875)#53134

Merged
afgomez merged 1 commit into
elastic:7.xfrom
afgomez:backport/7.x/pr-52875
Dec 17, 2019
Merged

[7.x] [Logs + Metrics UI] Use getTraceURL for APM trace links (#52875)#53134
afgomez merged 1 commit into
elastic:7.xfrom
afgomez:backport/7.x/pr-52875

Conversation

@afgomez
Copy link
Copy Markdown
Contributor

@afgomez afgomez commented Dec 16, 2019

Backports the following commits to 7.x:

[Logs + Metrics UI] Use getTraceURL for APM trace links (elastic#52875
c7dd472 
)

* Use `getTraceURL` for APM trace links

* Fix tests

* Check for the presence of APM links

Since now we use a helper provided by APM it no longer makes sense to
test for the actual URL (because that only tests the function). Instead
just test that the link exists and that it has an `href`.
@afgomez afgomez added the backport This PR is a backport of another PR label Dec 16, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2019

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 96202ea into elastic:7.x Dec 17, 2019
@afgomez afgomez deleted the backport/7.x/pr-52875 branch December 17, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afgomez @elasticmachine