Remove ui/persisted_log - Part 2#47236
Merged
lizozom merged 8 commits intoelastic:masterfrom Oct 6, 2019
Merged
Conversation
26 tasks
Contributor
💔 Build Failed
|
Contributor
💔 Build Failed
|
lizozom
force-pushed
the
newplatform/data-plugin/persisted-log-2
branch
from
dd57651 to
8095e01
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
lizozom
added
Feature:NP Migration
release_note:plugin_api_changes
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
💚 Build Succeeded |
46 tasks
30 tasks
streamich
approved these changes
Oct 4, 2019
kertal
approved these changes
Oct 4, 2019
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally in Chrome
…plugin/persisted-log-2
Contributor
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Oct 6, 2019
* Added storage interface to avoid importing ui/storage * Move persisted log into data plugin / query * Fix jest tests * import getQueryLog * Add store to graph search bar * Added window localStorage * Deleted persisted log folder
lizozom
pushed a commit
that referenced
this pull request
Oct 6, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 7, 2019
… into console-token-iterator * 'console-token-iterator' of github.com:jloleysens/kibana: (184 commits) [functional/services] update webdriver lib and types (elastic#47381) Standardizing IconField implementation across the app (elastic#47196) Move ui/value_suggestions ⇒ NP data plugin (elastic#45762) Remove ui/persisted_log - Part 2 (elastic#47236) Update gulp related packages (elastic#47421) Update dependency idx to ^2.5.6 (elastic#47399) try running fewer jobs in parallel on the same worker (elastic#47403) Update webpack related packages (elastic#47402) Update jsonwebtoken related packages (elastic#47400) Update gulp related packages (major) (elastic#46665) Update dependency prettier to ^1.18.2 (elastic#47340) Update dependency @types/puppeteer to ^1.20.1 (elastic#47339) Update dependency @elastic/elasticsearch to ^7.4.0 (elastic#47338) Update dependency tar-fs to ^1.16.3 (elastic#47341) [Code] Code Integrator Component (elastic#47180) [Canvas][i18n] Sidebar (elastic#46090) Generate uuid in task Manager as Kibana uuid may not yet have been initialised [Code] Embedded Code Snippet Component (elastic#47183) Revert "Add pipeline for flaky test runner job (elastic#46740)" SearchSource: fix docvalue_fields and fields intersection logic (elastic#46724) ...
Contributor
|
@lizozom can you please add a DevDocs section? |
Contributor
💔 Build Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dev Docs
Moved
persisted_logfromsrc/legacy/ui/public/persisted_log/persisted_log.ts→src/legacy/core_plugins/data/public/query/persisted_log/persisted_log.tsNo changes were made to interface.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers