[Code] Embedded Code Snippet Component by rylnd · Pull Request #47183 · elastic/kibana

rylnd · 2019-10-03T00:13:59Z

Summary

This addresses elastic/code#1635.

Adds new route for integrations work, hidden behind a config var (xpack.code.integrations.enabled)
Adds mock data to simulate what API consumers would be passing to these integration components
Updates CodeBlock component to minimize the API and make it more general
- Adds defaultProps as appropriate to remove boilerplate
- Minor style tweaks on the existing CodeBlock component

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-10-03T00:14:01Z

Pinging @elastic/code (Team:Code)

rylnd · 2019-10-03T00:15:09Z

@mw-ding same caveats here as mentioned in #47180 (comment).

elasticmachine · 2019-10-03T01:32:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 6ed7e30c58a3731e62b418506fafe5d532dac5ee

elasticmachine · 2019-10-03T20:06:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 9cc0c43c4e0f821d6a41b2d8ed8495e5e19b7bbb

x-pack/legacy/plugins/code/public/components/codeblock/embedded_codeblock.tsx

mw-ding

I skipped the part for the import selector and I am going to comment on the other PR.

For this one, I leave some minor comments inline. I think let's target on finalizing the EmbeddedCodeBlock interface and send out for review today or tomorrow?

mw-ding · 2019-10-03T20:58:20Z

x-pack/legacy/plugins/code/public/components/integrations/data.ts

This would be the eventual API that APM team will pass through. Shall we export these type definitions and the EmbeddedCodeBlock component to code/public/index.ts as we have chatted?

also, we probably need to provide a util function to convert APM's code context data into this shape. I will paste around a sample APM stacktrace data here later.

x-pack/legacy/plugins/code/public/components/integrations/data.ts

mw-ding · 2019-10-03T21:04:31Z

x-pack/legacy/plugins/code/index.ts

please rebase because of this change: #46664. For this flag, just leave here as the xpack.code.integrations.enabled flag does.

This was rebased onto master; it wasn't obvious what needed to change and there were no conflicts, so nothing really changed here. Please give this another look.

It should be OK then.

elasticmachine · 2019-10-04T00:42:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8f1dcf0747af641ce4c9102d0689fc528b0dd545

* Adds new route hidden behind a config var (`xpack.code.integrations.enabld`) * Updates CodeBlock component to have a smaller API surface * Adds several example components for various pieces of the new APM integration designs.

elasticmachine · 2019-10-04T04:12:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3b5fc1a

mw-ding

LGTM.

Hits and ranges were both part of our search results queries; O11y won't have that information.

mw-ding · 2019-10-04T21:29:23Z

@daveyholler this one as well. :)

x-pack/legacy/plugins/code/public/components/integrations/integrations.scss

elasticmachine · 2019-10-04T22:26:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 306264f

rylnd · 2019-10-04T22:35:26Z

retest

elasticmachine · 2019-10-04T23:44:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 306264f

* Add Integrations page and POC CodeBlock usage * Adds new route hidden behind a config var (`xpack.code.integrations.enabld`) * Updates CodeBlock component to have a smaller API surface * Adds several example components for various pieces of the new APM integration designs. * Pare down stub data Hits and ranges were both part of our search results queries; O11y won't have that information.

… into console-token-iterator * 'console-token-iterator' of github.com:jloleysens/kibana: (184 commits) [functional/services] update webdriver lib and types (elastic#47381) Standardizing IconField implementation across the app (elastic#47196) Move ui/value_suggestions ⇒ NP data plugin (elastic#45762) Remove ui/persisted_log - Part 2 (elastic#47236) Update gulp related packages (elastic#47421) Update dependency idx to ^2.5.6 (elastic#47399) try running fewer jobs in parallel on the same worker (elastic#47403) Update webpack related packages (elastic#47402) Update jsonwebtoken related packages (elastic#47400) Update gulp related packages (major) (elastic#46665) Update dependency prettier to ^1.18.2 (elastic#47340) Update dependency @types/puppeteer to ^1.20.1 (elastic#47339) Update dependency @elastic/elasticsearch to ^7.4.0 (elastic#47338) Update dependency tar-fs to ^1.16.3 (elastic#47341) [Code] Code Integrator Component (elastic#47180) [Canvas][i18n] Sidebar (elastic#46090) Generate uuid in task Manager as Kibana uuid may not yet have been initialised [Code] Embedded Code Snippet Component (elastic#47183) Revert "Add pipeline for flaky test runner job (elastic#46740)" SearchSource: fix docvalue_fields and fields intersection logic (elastic#46724) ...

* Add Integrations page and POC CodeBlock usage * Adds new route hidden behind a config var (`xpack.code.integrations.enabld`) * Updates CodeBlock component to have a smaller API surface * Adds several example components for various pieces of the new APM integration designs. * Pare down stub data Hits and ranges were both part of our search results queries; O11y won't have that information.

rylnd added Team:Code release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Oct 3, 2019

rylnd requested review from daveyholler, mw-ding and spacedragon October 3, 2019 00:13

rylnd requested a review from a team as a code owner October 3, 2019 00:13

rylnd force-pushed the code-integrations-snippet branch from 6ed7e30 to 9cc0c43 Compare October 3, 2019 18:46

mw-ding reviewed Oct 3, 2019

View reviewed changes

x-pack/legacy/plugins/code/public/components/codeblock/embedded_codeblock.tsx Outdated Show resolved Hide resolved

mw-ding reviewed Oct 3, 2019

View reviewed changes

rylnd force-pushed the code-integrations-snippet branch from d40db03 to 8f1dcf0 Compare October 3, 2019 23:32

Add Integrations page and POC CodeBlock usage

3b5fc1a

* Adds new route hidden behind a config var (`xpack.code.integrations.enabld`) * Updates CodeBlock component to have a smaller API surface * Adds several example components for various pieces of the new APM integration designs.

rylnd force-pushed the code-integrations-snippet branch from 8f1dcf0 to 3b5fc1a Compare October 4, 2019 03:02

rylnd mentioned this pull request Oct 4, 2019

[Code] Code Integrator Component #47180

Merged

7 tasks

mw-ding approved these changes Oct 4, 2019

View reviewed changes

Pare down stub data

306264f

Hits and ranges were both part of our search results queries; O11y won't have that information.

daveyholler suggested changes Oct 4, 2019

View reviewed changes

x-pack/legacy/plugins/code/public/components/integrations/integrations.scss Show resolved Hide resolved

rylnd requested a review from daveyholler October 4, 2019 23:34

daveyholler approved these changes Oct 4, 2019

View reviewed changes

rylnd merged commit c505fcb into elastic:master Oct 5, 2019

rylnd deleted the code-integrations-snippet branch October 5, 2019 00:02

rylnd mentioned this pull request Oct 5, 2019

[7.x] [Code] Embedded Code Snippet Component (#47183) #47391

Merged

Conversation

rylnd commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 3, 2019

Uh oh!

rylnd commented Oct 3, 2019

Uh oh!

elasticmachine commented Oct 3, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 3, 2019

💔 Build Failed

Uh oh!

Uh oh!

mw-ding left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mw-ding Oct 3, 2019

Choose a reason for hiding this comment

Uh oh!

mw-ding Oct 3, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mw-ding Oct 3, 2019

Choose a reason for hiding this comment

Uh oh!

rylnd Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

mw-ding Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 4, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 4, 2019

💚 Build Succeeded

Uh oh!

mw-ding left a comment

Choose a reason for hiding this comment

Uh oh!

mw-ding commented Oct 4, 2019

Uh oh!

Uh oh!

elasticmachine commented Oct 4, 2019

💔 Build Failed

Uh oh!

rylnd commented Oct 4, 2019

Uh oh!

elasticmachine commented Oct 4, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rylnd commented Oct 3, 2019 •

edited

Loading

mw-ding left a comment •

edited

Loading