Move ui/value_suggestions ⇒ NP data plugin by lizozom · Pull Request #45762 · elastic/kibana

lizozom · 2019-09-16T10:47:44Z

Summary

Move ui/value_suggestions ⇒ NP data plugin
Update value_suggestions to use core.http instead of kfetch and 'uiSettings'
Re-write x-pack/legacy/plugins/kuery_autocomplete/public/autocomplete_providers/value.test.js from karma to jest. The tests used to mostly test the underlying value_suggestions. I updated them to test the kuery_autocomplete provider instead.

FilterBar

Replace uiSettings that were passed around FilterBar components, with using the useKibana hook.
FilterBar to create it's own context with wrapInContextIfMissing if instantiated from angular
Pass NP data plugin to KibanaContextProvider to have access to autocomplete and getSuggestions

Dev Docs

Move value_suggestions into NP and expose data.getSuggestions on start contract.

In old platform:

    import { npStart } from 'ui/new_platform';
    const suggestions = await npStart.plugins.data.getSuggestions(indexPattern.title, field, value);

In new platform:

    public start(core, plugins) {
       ...
       const suggestions = await plugins.data.getSuggestions(indexPattern.title, field, value);
    }

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-16T12:24:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-23T16:26:14Z

Pinging @elastic/kibana-app-arch

elasticmachine · 2019-09-23T17:26:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-23T17:57:22Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Pass storage and autocomplete to createSearchBar method Add appName and autocomplete to IDataPluginServices QueryBarInput to consume autocomplete and appName from context QueryBarTopRow to consume appName from context Remove appName from SearchBar Added AutocompletePublicPluginSetup and AutocompletePublicPluginStart types

elasticmachine · 2019-10-02T22:01:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: fff2186

flash1293

Graph and Lens changes LGTM

…plugin/value-suggesions

elasticmachine · 2019-10-03T12:03:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 99f67ae

elasticmachine · 2019-10-03T12:44:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a992310

lizozom · 2019-10-03T14:32:51Z

retest

elasticmachine · 2019-10-03T14:42:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 03cd33c

…plugin/value-suggesions

elasticmachine · 2019-10-03T15:49:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 03cd33c

elasticmachine · 2019-10-03T16:46:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: dad955f

streamich

Code LGTM

streamich · 2019-10-04T11:38:34Z

src/plugins/data/public/plugin.ts

      autocomplete: this.autocomplete,
+      getSuggestions: getSuggestionsProvider(core.uiSettings, core.http),


In data plugin we have this services pattern where each service is returned from life-cycles, here autocomplete and getSuggestions are some utilities. Should we collect them into a service, say suggestions?

I actually thought of placing it inside the autocomplete service.
I just wasn't sure and didn't want to create unnecessary code while not sure.
Until we have a good hunch, I think the services pattern is great for more complex things, than a single function.

…plugin/value-suggesions

…:lizozom/kibana into newplatform/data-plugin/value-suggesions

elasticmachine · 2019-10-06T14:25:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0d983f5

* Bind search bar * create prewired data components * Pass NP data plugin to shim plugin, to access autocomplete Pass storage and autocomplete to createSearchBar method Add appName and autocomplete to IDataPluginServices QueryBarInput to consume autocomplete and appName from context QueryBarTopRow to consume appName from context Remove appName from SearchBar Added AutocompletePublicPluginSetup and AutocompletePublicPluginStart types * Use KibanaContextProvider in vis editor and graph * Use KibanaContextProvider in maps * Use prewirted SearchBar in TopNavMenu * Use KibanaContextProbider in Lens * Fix appName usage in query bar input * fixed query bar top row appName * update tests * fixed bind search bar bug * mock SearchBar * Removed unnecessary mocks * Delete unused mock * Fixed exporting of data plugin types * Updated maps snapshot * Fixed some TS issues * Fixed jest tests * Context adjustments in TSVB * componentWillMount * Code review fixes * Pass dataTestSubj to query bar input * Graph data * - Pass NP data plugin to KibanaReactContext - Move value_suggestions to NP * - Pass NP data plugin to KibanaReactContext - Move value_suggestions to NP * ts fixes * Added karma getSuggestions fake * Refactored kuery autocomplete tests to jest * Filter bar context for directives * updated snapshot * fix diffs * fixed lens test

… into console-token-iterator * 'console-token-iterator' of github.com:jloleysens/kibana: (184 commits) [functional/services] update webdriver lib and types (elastic#47381) Standardizing IconField implementation across the app (elastic#47196) Move ui/value_suggestions ⇒ NP data plugin (elastic#45762) Remove ui/persisted_log - Part 2 (elastic#47236) Update gulp related packages (elastic#47421) Update dependency idx to ^2.5.6 (elastic#47399) try running fewer jobs in parallel on the same worker (elastic#47403) Update webpack related packages (elastic#47402) Update jsonwebtoken related packages (elastic#47400) Update gulp related packages (major) (elastic#46665) Update dependency prettier to ^1.18.2 (elastic#47340) Update dependency @types/puppeteer to ^1.20.1 (elastic#47339) Update dependency @elastic/elasticsearch to ^7.4.0 (elastic#47338) Update dependency tar-fs to ^1.16.3 (elastic#47341) [Code] Code Integrator Component (elastic#47180) [Canvas][i18n] Sidebar (elastic#46090) Generate uuid in task Manager as Kibana uuid may not yet have been initialised [Code] Embedded Code Snippet Component (elastic#47183) Revert "Add pipeline for flaky test runner job (elastic#46740)" SearchSource: fix docvalue_fields and fields intersection logic (elastic#46724) ...

rayafratkina · 2019-11-13T21:48:52Z

@lizozom can you please add a DevDocs section?

elasticmachine · 2019-11-14T18:15:49Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0d983f5

lizozom mentioned this pull request Sep 16, 2019

Move Filter \ Timefilter \ Query Services ⇒ NP #44377

Closed

26 tasks

lizozom marked this pull request as ready for review September 23, 2019 16:25

lizozom changed the title ~~Newplatform/data plugin/value suggesions~~ Move ui/value_suggestions ⇒ data plugin Sep 23, 2019

lizozom changed the title ~~Move ui/value_suggestions ⇒ data plugin~~ Move ui/value_suggestions ⇒ data plugin Sep 23, 2019

lizozom changed the title ~~Move ui/value_suggestions ⇒ data plugin~~ Move ui/value_suggestions ⇒ data plugin Sep 23, 2019

lizozom self-assigned this Sep 23, 2019

lizozom added Feature:NP Migration Team:AppArch v7.5.0 v8.0.0 labels Sep 23, 2019

lizozom added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review labels Sep 23, 2019

alexwizp mentioned this pull request Sep 24, 2019

Shim ui/autocomplete_providers into legacy data plugin #46138

Merged

10 tasks

Liza K added 13 commits September 26, 2019 14:31

Bind search bar

e22d673

create prewired data components

0c7eebf

Use KibanaContextProvider in vis editor and graph

c4525e9

Use KibanaContextProvider in maps

995bfeb

Use prewirted SearchBar in TopNavMenu

1d09108

Use KibanaContextProbider in Lens

08fed2f

Fix appName usage in query bar input

b4ce1f2

fixed query bar top row appName

7e2740c

update tests

35d365e

fixed bind search bar bug

4dd148d

mock SearchBar

4913548

Removed unnecessary mocks

c836679

flash1293 approved these changes Oct 3, 2019

View reviewed changes

Liza K added 3 commits October 3, 2019 13:50

Refactored kuery autocomplete tests to jest

64f4566

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

99f67ae

…plugin/value-suggesions

Filter bar context for directives

a992310

lizozom requested review from ppisljar and streamich October 3, 2019 11:58

updated snapshot

03cd33c

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

dad955f

…plugin/value-suggesions

streamich approved these changes Oct 4, 2019

View reviewed changes

Liza K added 5 commits October 6, 2019 14:12

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

6fe474c

…plugin/value-suggesions

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

c719a2b

…plugin/value-suggesions

Merge branch 'newplatform/data-plugin/value-suggesions' of github.com…

f226ffa

…:lizozom/kibana into newplatform/data-plugin/value-suggesions

fix diffs

d7e3cd4

fixed lens test

0d983f5

lizozom merged commit 0c001e4 into elastic:master Oct 6, 2019

lizozom mentioned this pull request Oct 6, 2019

[7.x] Move ui/value_suggestions ⇒ NP data plugin (#45762) #47425

Merged

lizozom deleted the newplatform/data-plugin/value-suggesions branch November 14, 2019 13:03

		autocomplete: this.autocomplete,
		getSuggestions: getSuggestionsProvider(core.uiSettings, core.http),

Conversation

lizozom commented Sep 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

FilterBar

Dev Docs

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 16, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 23, 2019

Uh oh!

elasticmachine commented Sep 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 2, 2019

💔 Build Failed

Uh oh!

flash1293 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 3, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 3, 2019

💔 Build Failed

Uh oh!

lizozom commented Oct 3, 2019

Uh oh!

elasticmachine commented Oct 3, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 3, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 3, 2019

💚 Build Succeeded

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

streamich Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

lizozom Oct 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 6, 2019

💚 Build Succeeded

Uh oh!

rayafratkina commented Nov 13, 2019

Uh oh!

elasticmachine commented Nov 14, 2019

💔 Build Failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lizozom commented Sep 16, 2019 •

edited

Loading

flash1293 left a comment •

edited

Loading

lizozom Oct 6, 2019 •

edited

Loading