Merged
Conversation
thompsongl
added
v8.0.0
release_note:skip
cchaos
approved these changes
Sep 30, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thanks @thompsongl . LGTM once the snaps are updated.
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
snide
approved these changes
Sep 30, 2019
legrego
approved these changes
Oct 1, 2019
Member
legrego
left a comment
legrego
left a comment
There was a problem hiding this comment.
Not sure if you actually need the review, but security changes LGTM!
Contributor
Author
|
Just one very small change for @elastic/kibana-canvas code owners. Other request is just for snapshot updates. |
Contributor
|
We're merging this. I checked over the changes. They look pretty small or are snapshot related. |
thompsongl
added a commit
to thompsongl/kibana
that referenced
this pull request
Oct 3, 2019
* eui to 14.4.0 * euicard ts updates * snaps
thompsongl
added a commit
that referenced
this pull request
Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
14.4.0EuiEmptyPromptandEuiCardto TS (#2387)lensAppicon (#2389)EuiKeyPadMenuItembeta badge smaller (#2388)