Migrate EuiEmptyPromptand EuiCard to TS#2387
Merged
pugnascotia merged 3 commits intoelastic:masterfrom Sep 27, 2019
Merged
Conversation
This required some tweaks in a few places.
chandlerprall
approved these changes
Sep 27, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Thanks again! Changes LGTM
thompsongl
approved these changes
Sep 27, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Just the changelog update. We'll have a couple things to clean up in Kibana, but these changes look good
| - Added `visAreaStacked`, `visBarVerticalStacked`, and `visBarHorizontalStacked` icons to glyph set ([#2379](https://github.com/elastic/eui/pull/2379)) | ||
| - Adjusted style of beta badge on `EuiKeyPadMenuItem` ([#2375](https://github.com/elastic/eui/pull/2375)) | ||
| - Migrate `EuiFacetGroup`, `EuiKeyPadMenu` and `EuiCallOut` to TS ([#2382](https://github.com/elastic/eui/pull/2382)) | ||
| - Migrate `EuiEmptyPrompt`and `EuiCard` to TS ([#2387](https://github.com/elastic/eui/pull/2387)) |
Contributor
There was a problem hiding this comment.
Move this to master; we just had a release
snide
pushed a commit
to snide/eui
that referenced
this pull request
Oct 10, 2019
This required some tweaks in a few places. * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
EuiEmptyPromptandEuiCardto TypeScript. I had to fiddle with a few other files to support this work.Checklist