Made EuiKeyPadMenuItem beta badge smaller#2388
Merged
cchaos merged 4 commits intoelastic:masterfrom Sep 27, 2019
Merged
Conversation
snide
approved these changes
Sep 27, 2019
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
LGTM, ty for variabilizing. Checked code and ran locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating Kibana to use the better styles for the beta badge in the visualization picker, the beta badges still looked quite awkward mainly because of their size.
This PR reduces their size from
24x24to20x20and darkens the text/fill color to the fullest shade. This helps a ton.Before
After
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes