Migrate EuiBottomBar, EuiHealth and EuiImage to TS#2328
Merged
pugnascotia merged 7 commits intoelastic:masterfrom Sep 13, 2019
Merged
Migrate EuiBottomBar, EuiHealth and EuiImage to TS#2328pugnascotia merged 7 commits intoelastic:masterfrom
pugnascotia merged 7 commits intoelastic:masterfrom
Conversation
Contributor
|
cc @miukimiu for awareness as I think this might conflict a bit with #2287 |
The `yarn build` command was failing due to wierdness around the `PADDING_SIZES` export from `bottom_bar.tsx`. Remove it, and essentially move it to the test file, which is the only usage I could find (I checked Kibana too).
pugnascotia
force-pushed
the
i-cant-even-typescript
branch
from
3df5345 to
c17ff11
Compare
thompsongl
suggested changes
Sep 12, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks as always, @pugnascotia!
Contributor
Author
|
Thanks @thompsongl, I've addressed your comments. |
thompsongl
suggested changes
Sep 13, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Missed this before. Need HTMLElement attributes so things like style can be spread
Contributor
Author
|
@thompsongl updated again! |
thompsongl
approved these changes
Sep 13, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @pugnascotia!
@miukimiu If this merges before #2287, I'll get you a PR that'll resolve the merge conflicts in your branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
EuiBottomBar,EuiHealthandEuiImageto TS.Checklist