Merged
Conversation
Contributor
💔 Build Failed |
Contributor
|
Pinging @elastic/kibana-app-arch |
stacey-gammon
force-pushed
the
2019-08-12-per-panel-time-range-2
branch
2 times, most recently
from
2274cd4 to
4e69320
Compare
Contributor
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-08-12-per-panel-time-range-2
branch
2 times, most recently
from
e3b330a to
aa0698c
Compare
Contributor
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-08-12-per-panel-time-range-2
branch
2 times, most recently
from
d5ea540 to
18b3c1b
Compare
stacey-gammon
force-pushed
the
2019-08-12-per-panel-time-range-2
branch
from
18b3c1b to
62cb62f
Compare
Contributor
💚 Build Succeeded |
streamich
approved these changes
Aug 14, 2019
Contributor
streamich
left a comment
streamich
left a comment
There was a problem hiding this comment.
Please see comments about awaiting isCompatible(), otherwise LGTM.
Ran locally on Mac/Chrome.
...k/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.test.ts
Show resolved
Hide resolved
...k/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.test.ts
Outdated
Show resolved
Hide resolved
...k/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.tsx
Show resolved
Hide resolved
| } | ||
| )} | ||
| > | ||
| <EuiSuperDatePicker |
Contributor
There was a problem hiding this comment.
Didn't know we have "super" date picker.
x-pack/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_badge.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/advanced_ui_actions/public/np_ready/public/custom_time_range_action.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 14, 2019
* Per panel time range * Added tests and fixed lack of await check for incompatibility * Remove a couple more unneccessary `anys`
stacey-gammon
pushed a commit
that referenced
this pull request
Aug 14, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 15, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
2 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each panel on a dashboard can now be configured to show a custom time range, independent from the global one. Just go to the menu options and select
Customize time range. If the panel's time range is different than what is showing in the global time picker, it will contain a visible badge showing the date.fixes #17776 and #3578