[csp] Telemetry for csp configuration#43223
Merged
epixa merged 3 commits intoelastic:masterfrom Aug 14, 2019
Merged
Conversation
We collect the boolean configurations which can be derived by any end-user of Kibana by making any HTTP request. Since the rules configuration involves strings that can leak identifiable information, we only collect whether the rules have been changed from their defaults.
epixa
added
release_note:enhancement
Team:Security
Contributor
|
Pinging @elastic/kibana-security |
Contributor
💚 Build Succeeded |
kobelb
reviewed
Aug 14, 2019
x-pack/legacy/plugins/oss_telemetry/server/lib/collectors/csp/csp_collector.ts
Show resolved
Hide resolved
x-pack/legacy/plugins/oss_telemetry/server/lib/collectors/csp/csp_collector.ts
Show resolved
Hide resolved
x-pack/legacy/plugins/oss_telemetry/server/lib/collectors/csp/csp_collector.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/oss_telemetry/server/lib/collectors/csp/csp_collector.test.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I relaxed the reliance on the constant defaults and switched the rule check over to a snapshot. |
kobelb
approved these changes
Aug 14, 2019
Contributor
kobelb
left a comment
kobelb
left a comment
There was a problem hiding this comment.
LGTM - apologies for all the nits
Contributor
💚 Build Succeeded |
epixa
added a commit
that referenced
this pull request
Aug 14, 2019
We collect the boolean configurations which can be derived by any end-user of Kibana by making any HTTP request. Since the rules configuration involves strings that can leak identifiable information, we only collect whether the rules have been changed from their defaults.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 15, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We collect the boolean configurations which can be derived by any
end-user of Kibana by making any HTTP request. Since the rules
configuration involves strings that can leak identifiable information,
we only collect whether the rules have been changed from their defaults.
The following shape is added to the telemetry payload: