[Embeddables] Time range per panel design fixes#46630
Merged
cchaos merged 4 commits intoelastic:masterfrom Sep 28, 2019
Merged
Conversation
cchaos
added
Feature:Dashboard
Contributor
|
Pinging @elastic/kibana-app-arch |
Contributor
💚 Build Succeeded |
cchaos
force-pushed
the
time-range-per-panel-design-fix
branch
from
07f035f to
b0e4cb4
Compare
Contributor
💚 Build Succeeded |
Contributor
|
While we are at it, maybe we can align date picker to the right.
|
Contributor
|
It seems padding between time range and the top border disappears when there is no text:
|
streamich
approved these changes
Sep 27, 2019
Contributor
streamich
left a comment
streamich
left a comment
There was a problem hiding this comment.
LGTM, checked on Mac/Chrome.
Contributor
Author
|
Thanks @streamich, good catch on the padding. I'll get that fixed. |
Contributor
Author
|
Fixed alignment.
|
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes were originally created to support #39937 & #43153 but never got merged in.
1. Fixed loading icon which should have been centered
2. Fixed spacing of the modal's footer buttons
3. Fixed issues with the time badge being pushed out of view of skinny panels
4. Fixed placement of the description indicator
It used to come after the badge so it would also get push out of view. Now I put it between the text and the time badge but the text still truncates leaving the description icon always in view stuck to the right of the panel.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility