[Watcher] Reverting incorrectly removed scope parameters#37875
Merged
jgowdyelastic merged 2 commits intoJun 4, 2019
Merged
Conversation
jgowdyelastic
added
bug
Contributor
💔 Build Failed |
Member
Author
|
retest |
jgowdyelastic
force-pushed
the
watcher-fixing-incorrectly-removed-scope-parameters
branch
from
81adebb to
1592a65
Compare
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
jgowdyelastic
deleted the
watcher-fixing-incorrectly-removed-scope-parameters
branch
jgowdyelastic
added a commit
that referenced
this pull request
Jun 4, 2019
* [Watcher] Reverting incorrectly removed scope parameters * removing no-unused-vars comments
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jun 27, 2019
* [Watcher] Reverting incorrectly removed scope parameters * removing no-unused-vars comments
jgowdyelastic
added a commit
that referenced
this pull request
Jun 28, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [Watcher] Reverting incorrectly removed scope parameters * removing no-unused-vars comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #37051 removed scope parameters in angular directives which are necessary for the directive to work.
Relates to #37873
Updated to match changes in #37922