Skip to content

[Watcher] Reverting incorrectly removed scope parameters #37875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgowdyelastic merged 2 commits into from
Jun 4, 2019
Merged

[Watcher] Reverting incorrectly removed scope parameters #37875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1592a65
[Watcher] Reverting incorrectly removed scope parameters
jgowdyelastic Jun 3, 2019
f36f190
removing no-unused-vars comments
jgowdyelastic Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/watcher/public/components/duration_select/duration_select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ app.directive('durationSelect', function ($injector) {
replace: true,
controllerAs: 'durationSelect',
bindToController: true,
link: function ($scope, $ctrl) {
link: function ($scope, $element, $attrs, $ctrl) {
$scope.durationSelect.form = $ctrl;
},
controller: class DurationSelectController extends InitAfterBindingsWorkaround {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/watcher/public/components/kbn_tabs/components/kbn_tab/kbn_tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ app.directive('kbnTab', function () {
controllerAs: 'kbnTab',
bindToController: true,
controller: class KbnTabController {},
link: function ($scope, kbnTabs) {
link: function ($scope, $ele, attrs, kbnTabs) {
$scope.kbnTabs = kbnTabs;
}
};
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/watcher/public/components/xpack_aria_describes/xpack_aria_describes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const app = uiModules.get('xpack/watcher');
app.directive('xpackAriaDescribes', function () {
return {
restrict: 'A',
link: function ($scope, attr) {
link: function ($scope, $ele, attr) {
if (!Object.keys(attr).includes('id')) {
throw new Error(`An element with xpack-aria-describes="${attr.xpackAriaDescribes}" does not have an id attribute defined`);
}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/watcher/public/directives/json_input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ uiModules
return {
restrict: 'A',
require: 'ngModel',
link: function (scope, attrs, ngModelCntrl) {
link: function (scope, $el, attrs, ngModelCntrl) {
ngModelCntrl.$formatters.push(toJSON);
ngModelCntrl.$parsers.push(fromJSON);

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/watcher/public/directives/tooltip/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ uiModules.get('xpack/watcher')
transclude: true,
replace: true,
scope: true,
link: function ($scope, attr) {
link: function ($scope, $el, attr) {
$scope.text = attr.text;
$scope.placement = attr.placement || 'top';
$scope.delay = attr.delay || 400;
Expand Down