Skip to content

remove unneeded eslint-disable directives#37922

Merged
mattkime merged 2 commits into
elastic:masterfrom
mattkime:no_unused_vars_cleanup_set_two_revert
Jun 4, 2019
Merged

remove unneeded eslint-disable directives#37922
mattkime merged 2 commits into
elastic:masterfrom
mattkime:no_unused_vars_cleanup_set_two_revert

Conversation

@mattkime
Copy link
Copy Markdown
Contributor

@mattkime mattkime commented Jun 3, 2019 •
edited
Loading

Summary

This removes changes from #37051 that are in conflict with #36806

...just removing a bunch of // eslint-disable-line no-unused-vars statements since we've agreed not to enable enforcement.

@mattkime mattkime requested review from a team as code owners June 3, 2019 20:41
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 3, 2019

💚 Build Succeeded

@mattkime mattkime requested a review from walterra June 4, 2019 01:56
This was referenced Jun 4, 2019
Merged
Merged
peteharverson
peteharverson approved these changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@mattkime mattkime merged commit 964f9e2 into elastic:master Jun 4, 2019
mattkime added a commit to mattkime/kibana that referenced this pull request Jun 4, 2019
@mattkime
remove unneeded eslint-disable directives (elastic#37922)
1bf1966 
* remove unneeded eslint-disable directives
jgowdyelastic pushed a commit that referenced this pull request Jun 4, 2019
@mattkime @jgowdyelastic
remove unneeded eslint-disable directives (#37922)
bb68fdf 
* remove unneeded eslint-disable directives
@stacey-gammon
Copy link
Copy Markdown

stacey-gammon commented Jun 11, 2019

Does this need to get backported?

@timroes timroes added the release_note:skip Skip the PR/issue when compiling release notes label Apr 26, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 28, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 28, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

7 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 29, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 30, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 3, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 4, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 5, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 7, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37922 or prevent reminders by adding the backport:skip label.

@mattkime mattkime added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 7, 2021
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@mattkime
remove unneeded eslint-disable directives (elastic#37922)
5bf1f0a 
* remove unneeded eslint-disable directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobelb kobelb kobelb approved these changes

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mattkime @elasticmachine @stacey-gammon @kibanamachine @kobelb @peteharverson @timroes