[SR] Add SnapshotTable and SnapshotDetails. by cjcenizal · Pull Request #34837 · elastic/kibana

cjcenizal · 2019-04-09T23:59:28Z

Empty state (link goes to docs):

Loading (took 30s when I was testing; I'm talking with Yannick about what we can do about this on the ES side):

Table lists repository and snapshot as two separate columns, ordered from newest to oldest:

Details (WIP) are loaded with both repository and snapshot in the URL. Details load independently of the table so if you're deep-linked you can see the details immediately without waiting on the table:

Loading and missing states for detail panel:

Failures need some nicer formatting. I'll address this in another PR.

elasticmachine · 2019-04-09T23:59:30Z

Pinging @elastic/es-ui

elasticmachine · 2019-04-10T00:40:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2019-04-10T22:59:34Z

x-pack/plugins/snapshot_restore/public/app/components/repository_form/repository_form.tsx

@jen-huang Were you able to test this? I made a fix to the useRequest hook which I think takes care of this, so I removed it.

cjcenizal · 2019-04-10T23:00:38Z

x-pack/plugins/snapshot_restore/public/app/sections/home/snapshot_list/snapshot_list.tsx

@jen-huang I was able to remove the useState and useEffect hooks and just depend upon the route params. I think we can do the same thing for the RepositoryList.

cjcenizal · 2019-04-10T23:04:24Z

x-pack/plugins/snapshot_restore/public/app/services/http/use_request.ts

@jen-huang I found a couple resources [1][2] which indicate this as a pattern for cleaning up an effect. I ran into a couple console errors by leaving the Snapshots tab before the request had resolved, and adding this fixed them.

[1] https://reactjs.org/docs/hooks-effect.html#example-using-hooks-1
[2] https://reactjs.org/docs/hooks-reference.html#cleaning-up-an-effect

…hot. - Add snapshot column to table. - Retrieve complete snapshot details in getAllHandler. - Display and load detail panel while table is still loading. - Simplify detail-panel logic and update routes. - Fix cleanup function bug in useRequest hook.

elasticmachine · 2019-04-10T23:57:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…quest.

cjcenizal · 2019-04-11T01:45:37Z

x-pack/plugins/snapshot_restore/public/app/services/http/use_request.ts

-  const [loading, setLoading] = useState<boolean>(false);
-  const [data, setData] = useState<any>([]);
+  const [loading, setLoading] = useState<boolean>(true);
+  const [data, setData] = useState<any>(initialData);


@jen-huang The hardcoded [] value caused errors in situations where I either expected this value to be undefined or an object initially, so I added the ability to specify it per request.

cjcenizal · 2019-04-11T01:46:26Z

x-pack/plugins/snapshot_restore/public/app/services/http/use_request.ts

    loading,
    data,
    request,
-    setIsMounted: (status: boolean) => {


With the addition of the cleanup function return by useEffect call, I don't think is necessary.

elasticmachine · 2019-04-11T02:01:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-11T02:54:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…Data.

elasticmachine · 2019-04-11T04:16:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-11T04:19:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-04-11T05:07:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

- Remove route param aliases. - Remove unnecessary <em> tags.

elasticmachine · 2019-04-11T18:08:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…tracking outdated requests.

elasticmachine · 2019-04-11T20:14:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

jen-huang

I found a few minor things, and some suggestions which can be deferred, but overall nothing blocking so LGTM!

Thanks for working on this!

jen-huang · 2019-04-11T20:05:14Z

...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx

        <FormattedMessage
          id="xpack.snapshotRestore.repositoryDetails.loadingRepository"
-          defaultMessage="Loading repository..."
+          defaultMessage="Loading repository…"


is this an intentional change?

Thanks for checking! Yes, it is. This is better for localization purposes. I double-checked with Gail and she also approved.

jen-huang · 2019-04-11T20:05:26Z

x-pack/plugins/snapshot_restore/public/app/sections/home/repository_list/repository_list.tsx

        <FormattedMessage
          id="xpack.snapshotRestore.repositoryList.loadingRepositories"
-          defaultMessage="Loading repositories..."
+          defaultMessage="Loading repositories…"


is this an intentional change?

jen-huang · 2019-04-11T20:15:03Z

x-pack/plugins/snapshot_restore/public/app/sections/home/home.tsx

+          />
+          <Route
+            exact
+            path={`${BASE_PATH}/snapshots/:repositoryName?/:snapshotId*`}


this routing doesn't work for repository names with / in them. for example, set up a repository with the name foo/bar and add a snapshot into it. the detail panel will encounter a 404 error

splitting this route into two routes, one with a greedy capture on repositoryName seems to work:

<Route exact path={`${BASE_PATH}/snapshots`} component={SnapshotList} /> <Route exact path={`${BASE_PATH}/snapshots/:repositoryName*/:snapshotId`} component={SnapshotList} />

snapshot IDs have ES character restrictions, so we don't need to worry about / for them 😄

jen-huang · 2019-04-11T20:15:36Z

...napshot_restore/public/app/sections/home/snapshot_list/snapshot_details/snapshot_details.tsx

+    1: (
+      <FormattedMessage
+        id="xpack.snapshotRestore.snapshotDetails.itemIncludeGlobalStateYesLabel"
+        data-test-subj="srSnapshotDetailsIndicesNoneTitle"


this test subject is the same as L50, is it intentional?

jen-huang · 2019-04-11T20:16:46Z

...napshot_restore/public/app/sections/home/snapshot_list/snapshot_details/snapshot_details.tsx

+    ) : (
+      <FormattedMessage
+        id="xpack.snapshotRestore.snapshotDetails.itemIndicesNoneLabel"
+        data-test-subj="srSnapshotDetailsIndicesNoneTitle"


this test subject is the same as L50, is it intentional?

jen-huang · 2019-04-11T20:28:54Z

x-pack/plugins/snapshot_restore/public/app/sections/home/snapshot_list/snapshot_list.tsx

+      <SectionLoading>
+        <FormattedMessage
+          id="xpack.snapshotRestore.snapshotList.loadingSnapshots"
+          defaultMessage="Loading snapshots…"


do we prefer the ellipses character over ...?

jen-huang · 2019-04-11T20:30:20Z

...ns/snapshot_restore/public/app/sections/home/snapshot_list/snapshot_table/snapshot_table.tsx

+      truncateText: true,
+      sortable: true,
+      // We deliberately don't link to the repository from here because the API request for populating
+      // this table takes so long, and navigating away by accident is a really poor UX.


the request takes very little time with no erroneous repositories, so maybe we can reconsider this 😄

jen-huang · 2019-04-11T20:31:37Z

...ns/snapshot_restore/public/app/sections/home/snapshot_list/snapshot_table/snapshot_table.tsx

+      incremental: true,
+      schema: true,
+    },
+  };


it would be nice to add a filter on repository name!

Added to the to-do list!

jen-huang · 2019-04-11T20:32:26Z

x-pack/plugins/snapshot_restore/public/app/services/http/use_request.ts

-  const [loading, setLoading] = useState<boolean>(false);
-  const [data, setData] = useState<any>([]);
+  const [loading, setLoading] = useState<boolean>(true);
+  const [data, setData] = useState<any>(initialData);


jen-huang · 2019-04-11T20:34:23Z

x-pack/plugins/snapshot_restore/public/app/services/text/format_date.ts

+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+// @ts-ignore


we could define this in x-pack/typings/@elastic/eui to avoid having to ignore linting here

- Fix bug in useRequest which prevented old data from being cleared when subsequent requests returned errors. - Fix formatting bug for failures in detail panel. - Fix routing bug when repository name contains slashes. - Fix/remove test subject selectors. - Add EUI typing.

cjcenizal · 2019-04-11T23:28:46Z

Thanks for the review @jen-huang! I've updated with your feedback and will merge once CI is green.

elasticmachine · 2019-04-12T00:08:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* [SR] Snapshot and restore plugin boilerplate (#32276) * Initial plugin set up * Set up client shell * Add initial repository list routes * Fix merge issues and some typings * Decouple server from plugin.ts files, tighten up typings * Use exported constant for required license * Translate plugin name, more typings * Fix more types, move list components under /home * Remove unused var * Change scss prefix * Uncouple unmount logic from routing shim, and some other PR feedback * [SR] Repository list and details UI (#33367) * Initial pass at repositories list UI * Add detail panel for file system repositories, and a generic detail panel with json settings view * Add detail components for other types * Add detail panel footer, rename `useStateValue` to `useAppState` * Fix detail panel footer * Fix unused vars * PR feedback * PR feedback * [SR] Refactor proposal (#33690) * Move app dependencies to its own context provider * Add index.ts barrel file for common types * Move Enums to constants.ts file * Refactor function component using `React.FunctionComponent<Props>` * Refactor service folder structure * Fix type import * Move REPOSITORY_DOC_PATHS from common to public constants * Move AppCore and AppPlugins interfaces back to shim and re-export them from app types * [SR] Create and edit repositories UI (#34020) * Add routing and placeholder form * Fix typings * Set up edit repository route, and basic form UI * Add typings for wrapCustomError, and copy extractCausedByChain from CCR wrapEsError * Throw errors that are already boomified * Create and edit for basic repository types (fs, url, source) * Add repository verification UI to table and details * Create and edit for plugin repository types (hdfs, azure, s3, gcs) * Fix linting * Fix test * Fix test * Remove unused import * Fix duplicate i18n key * Fix details opening on cancel edit, remove unnecessary Fragments, definition file for some EUI components to x-pack, rename saveError * Remove breaks * Adjust add and edit repo routes so they don't conflict with list route * Add repo plugin and types doc links to form * Bootstrap documentation service * Bootstrap text service and replace RepositoryTypeName component with it * Bootstrap breadcrumb service and replace usages * Bootstrap httpService, remove chrome and http from app dependencies(!) * Add request creator and replace all instances of useRequest and sendRequest with it * Fix typo * Simplify update repository and update repository setting methods * Adjust copy * Lint * Remove unused var * Remove unused import * [SR] Add API for retrieving snapshots. (#34598) * [SR] Single and multiple repository delete (#34593) * Add single/multi repository delete API and UI * Address PR feedback * [SR] Add SnapshotTable and SnapshotDetails. (#34837) * Remove associations between multiple repositories with a single snapshot. * Retrieve complete snapshot details in getAllHandler. * Fix cleanup function bug in useRequest hook. * Fix bug in useRequest which prevented old data from being cleared when subsequent requests returned errors. * Add initialValue config option to useRequest. * Add formatDate service to text module. * [SR] Fix linting and add (de)serialization for repositories (#35031) * Fix eslint issues and add (de)serialization for repositories * Add comment about flattening settings * [SR] Surface repository errors and index failures more prominently (#35042) * Add links to repositories from Snapshot Table and Snapshot Details. - Rename services/breadcrumbs to services/navigation and add linkToRepository function. - Refactor home component to update active tab when URL was changed. * Add warning callout to let user know when their repositories contain errors. * Sort failures by shard and add test for snapshot serialization. * Sort failures and indices. * Add filter for filtering snapshots by their repository. * Surface states with humanized text, icons, and tooltips where necessary. * Fix pluralization of seconds. * Surface failures tab even if there are none. - Display a '-' for missing times and durations. - Create DataPlaceholder component. * [SR] Polish repositories UX (#35123) * Refactor repository detail panel to load repository based directly on route param. * Display repository detail panel while table is loading. * Make 'Edit repository' table action a link instead of a button. * Render disabled EuiSelect as a readonly EuiFieldText. * Prepend HDFS URI with hdfs:// protocol. * Present scheme options for Read-Only URL repository as a select. * [SR] Add client-side validation to repository form and link to snapshots from details (#35238) * Add client side repository form validation, extract `flatten` into common lib * Add snapshot count to repository details and link to snapshot list * Reset validation when changing repository type * Fix snapshot list filter deep linking for repository names with slashes and spaces * Fix imports * PR feedback * [SR] Design and copywriting fixes (#35591) * Split repository form into two steps; move `clean_settings.ts` to server * Default to snapshots tab, adjust snapshot empty prompt, add app description * Add minimum timeout to list view requests to avoid flicker, use EuiEmptyPrompt for loading screen, add doc link to settings step * Add information about snapshots to delete repository behavior, add doc link for source only toggle, add size notation help text * Add main doc link * Copywriting and i18n fixes, and add some common settings to third party repo types * Add fields to third party repo detail panel * More copywriting fixes * Use spinner for duration and end time if snapshotting is still in progress * Show all repository type options, mark missing plugins * Revert "Show all repository type options, mark missing plugins" This reverts commit e34ee47. * Fix space * [SR] Add permissions UI and Cloud-specific repository type UI branch (#35833) * Add missing permissions UI and cloud-specific repository type UI branch * Add ES UI as owners of /snapshot_restore directory * Add no repository types callout for Cloud edge case * Redirect invalid section param to repositories * Add warning empty prompt if all repositories have errrors * Replace repository cards with EuiCard * Add snapshot doc link to repository error empty prompt * Remove auto-verification from list and get routes, add separate verification route, add manual verification to repository detail panel * Update copy and remove obsolete test * Remove unused scss files * Final changes to repository cards

* [SR] Snapshot and restore plugin boilerplate (elastic#32276) * Initial plugin set up * Set up client shell * Add initial repository list routes * Fix merge issues and some typings * Decouple server from plugin.ts files, tighten up typings * Use exported constant for required license * Translate plugin name, more typings * Fix more types, move list components under /home * Remove unused var * Change scss prefix * Uncouple unmount logic from routing shim, and some other PR feedback * [SR] Repository list and details UI (elastic#33367) * Initial pass at repositories list UI * Add detail panel for file system repositories, and a generic detail panel with json settings view * Add detail components for other types * Add detail panel footer, rename `useStateValue` to `useAppState` * Fix detail panel footer * Fix unused vars * PR feedback * PR feedback * [SR] Refactor proposal (elastic#33690) * Move app dependencies to its own context provider * Add index.ts barrel file for common types * Move Enums to constants.ts file * Refactor function component using `React.FunctionComponent<Props>` * Refactor service folder structure * Fix type import * Move REPOSITORY_DOC_PATHS from common to public constants * Move AppCore and AppPlugins interfaces back to shim and re-export them from app types * [SR] Create and edit repositories UI (elastic#34020) * Add routing and placeholder form * Fix typings * Set up edit repository route, and basic form UI * Add typings for wrapCustomError, and copy extractCausedByChain from CCR wrapEsError * Throw errors that are already boomified * Create and edit for basic repository types (fs, url, source) * Add repository verification UI to table and details * Create and edit for plugin repository types (hdfs, azure, s3, gcs) * Fix linting * Fix test * Fix test * Remove unused import * Fix duplicate i18n key * Fix details opening on cancel edit, remove unnecessary Fragments, definition file for some EUI components to x-pack, rename saveError * Remove breaks * Adjust add and edit repo routes so they don't conflict with list route * Add repo plugin and types doc links to form * Bootstrap documentation service * Bootstrap text service and replace RepositoryTypeName component with it * Bootstrap breadcrumb service and replace usages * Bootstrap httpService, remove chrome and http from app dependencies(!) * Add request creator and replace all instances of useRequest and sendRequest with it * Fix typo * Simplify update repository and update repository setting methods * Adjust copy * Lint * Remove unused var * Remove unused import * [SR] Add API for retrieving snapshots. (elastic#34598) * [SR] Single and multiple repository delete (elastic#34593) * Add single/multi repository delete API and UI * Address PR feedback * [SR] Add SnapshotTable and SnapshotDetails. (elastic#34837) * Remove associations between multiple repositories with a single snapshot. * Retrieve complete snapshot details in getAllHandler. * Fix cleanup function bug in useRequest hook. * Fix bug in useRequest which prevented old data from being cleared when subsequent requests returned errors. * Add initialValue config option to useRequest. * Add formatDate service to text module. * [SR] Fix linting and add (de)serialization for repositories (elastic#35031) * Fix eslint issues and add (de)serialization for repositories * Add comment about flattening settings * [SR] Surface repository errors and index failures more prominently (elastic#35042) * Add links to repositories from Snapshot Table and Snapshot Details. - Rename services/breadcrumbs to services/navigation and add linkToRepository function. - Refactor home component to update active tab when URL was changed. * Add warning callout to let user know when their repositories contain errors. * Sort failures by shard and add test for snapshot serialization. * Sort failures and indices. * Add filter for filtering snapshots by their repository. * Surface states with humanized text, icons, and tooltips where necessary. * Fix pluralization of seconds. * Surface failures tab even if there are none. - Display a '-' for missing times and durations. - Create DataPlaceholder component. * [SR] Polish repositories UX (elastic#35123) * Refactor repository detail panel to load repository based directly on route param. * Display repository detail panel while table is loading. * Make 'Edit repository' table action a link instead of a button. * Render disabled EuiSelect as a readonly EuiFieldText. * Prepend HDFS URI with hdfs:// protocol. * Present scheme options for Read-Only URL repository as a select. * [SR] Add client-side validation to repository form and link to snapshots from details (elastic#35238) * Add client side repository form validation, extract `flatten` into common lib * Add snapshot count to repository details and link to snapshot list * Reset validation when changing repository type * Fix snapshot list filter deep linking for repository names with slashes and spaces * Fix imports * PR feedback * [SR] Design and copywriting fixes (elastic#35591) * Split repository form into two steps; move `clean_settings.ts` to server * Default to snapshots tab, adjust snapshot empty prompt, add app description * Add minimum timeout to list view requests to avoid flicker, use EuiEmptyPrompt for loading screen, add doc link to settings step * Add information about snapshots to delete repository behavior, add doc link for source only toggle, add size notation help text * Add main doc link * Copywriting and i18n fixes, and add some common settings to third party repo types * Add fields to third party repo detail panel * More copywriting fixes * Use spinner for duration and end time if snapshotting is still in progress * Show all repository type options, mark missing plugins * Revert "Show all repository type options, mark missing plugins" This reverts commit e34ee47. * Fix space * [SR] Add permissions UI and Cloud-specific repository type UI branch (elastic#35833) * Add missing permissions UI and cloud-specific repository type UI branch * Add ES UI as owners of /snapshot_restore directory * Add no repository types callout for Cloud edge case * Redirect invalid section param to repositories * Add warning empty prompt if all repositories have errrors * Replace repository cards with EuiCard * Add snapshot doc link to repository error empty prompt * Remove auto-verification from list and get routes, add separate verification route, add manual verification to repository detail panel * Update copy and remove obsolete test * Remove unused scss files * Final changes to repository cards

* [SR] Snapshot and restore plugin boilerplate (#32276) * Initial plugin set up * Set up client shell * Add initial repository list routes * Fix merge issues and some typings * Decouple server from plugin.ts files, tighten up typings * Use exported constant for required license * Translate plugin name, more typings * Fix more types, move list components under /home * Remove unused var * Change scss prefix * Uncouple unmount logic from routing shim, and some other PR feedback * [SR] Repository list and details UI (#33367) * Initial pass at repositories list UI * Add detail panel for file system repositories, and a generic detail panel with json settings view * Add detail components for other types * Add detail panel footer, rename `useStateValue` to `useAppState` * Fix detail panel footer * Fix unused vars * PR feedback * PR feedback * [SR] Refactor proposal (#33690) * Move app dependencies to its own context provider * Add index.ts barrel file for common types * Move Enums to constants.ts file * Refactor function component using `React.FunctionComponent<Props>` * Refactor service folder structure * Fix type import * Move REPOSITORY_DOC_PATHS from common to public constants * Move AppCore and AppPlugins interfaces back to shim and re-export them from app types * [SR] Create and edit repositories UI (#34020) * Add routing and placeholder form * Fix typings * Set up edit repository route, and basic form UI * Add typings for wrapCustomError, and copy extractCausedByChain from CCR wrapEsError * Throw errors that are already boomified * Create and edit for basic repository types (fs, url, source) * Add repository verification UI to table and details * Create and edit for plugin repository types (hdfs, azure, s3, gcs) * Fix linting * Fix test * Fix test * Remove unused import * Fix duplicate i18n key * Fix details opening on cancel edit, remove unnecessary Fragments, definition file for some EUI components to x-pack, rename saveError * Remove breaks * Adjust add and edit repo routes so they don't conflict with list route * Add repo plugin and types doc links to form * Bootstrap documentation service * Bootstrap text service and replace RepositoryTypeName component with it * Bootstrap breadcrumb service and replace usages * Bootstrap httpService, remove chrome and http from app dependencies(!) * Add request creator and replace all instances of useRequest and sendRequest with it * Fix typo * Simplify update repository and update repository setting methods * Adjust copy * Lint * Remove unused var * Remove unused import * [SR] Add API for retrieving snapshots. (#34598) * [SR] Single and multiple repository delete (#34593) * Add single/multi repository delete API and UI * Address PR feedback * [SR] Add SnapshotTable and SnapshotDetails. (#34837) * Remove associations between multiple repositories with a single snapshot. * Retrieve complete snapshot details in getAllHandler. * Fix cleanup function bug in useRequest hook. * Fix bug in useRequest which prevented old data from being cleared when subsequent requests returned errors. * Add initialValue config option to useRequest. * Add formatDate service to text module. * [SR] Fix linting and add (de)serialization for repositories (#35031) * Fix eslint issues and add (de)serialization for repositories * Add comment about flattening settings * [SR] Surface repository errors and index failures more prominently (#35042) * Add links to repositories from Snapshot Table and Snapshot Details. - Rename services/breadcrumbs to services/navigation and add linkToRepository function. - Refactor home component to update active tab when URL was changed. * Add warning callout to let user know when their repositories contain errors. * Sort failures by shard and add test for snapshot serialization. * Sort failures and indices. * Add filter for filtering snapshots by their repository. * Surface states with humanized text, icons, and tooltips where necessary. * Fix pluralization of seconds. * Surface failures tab even if there are none. - Display a '-' for missing times and durations. - Create DataPlaceholder component. * [SR] Polish repositories UX (#35123) * Refactor repository detail panel to load repository based directly on route param. * Display repository detail panel while table is loading. * Make 'Edit repository' table action a link instead of a button. * Render disabled EuiSelect as a readonly EuiFieldText. * Prepend HDFS URI with hdfs:// protocol. * Present scheme options for Read-Only URL repository as a select. * [SR] Add client-side validation to repository form and link to snapshots from details (#35238) * Add client side repository form validation, extract `flatten` into common lib * Add snapshot count to repository details and link to snapshot list * Reset validation when changing repository type * Fix snapshot list filter deep linking for repository names with slashes and spaces * Fix imports * PR feedback * [SR] Design and copywriting fixes (#35591) * Split repository form into two steps; move `clean_settings.ts` to server * Default to snapshots tab, adjust snapshot empty prompt, add app description * Add minimum timeout to list view requests to avoid flicker, use EuiEmptyPrompt for loading screen, add doc link to settings step * Add information about snapshots to delete repository behavior, add doc link for source only toggle, add size notation help text * Add main doc link * Copywriting and i18n fixes, and add some common settings to third party repo types * Add fields to third party repo detail panel * More copywriting fixes * Use spinner for duration and end time if snapshotting is still in progress * Show all repository type options, mark missing plugins * Revert "Show all repository type options, mark missing plugins" This reverts commit e34ee47. * Fix space * [SR] Add permissions UI and Cloud-specific repository type UI branch (#35833) * Add missing permissions UI and cloud-specific repository type UI branch * Add ES UI as owners of /snapshot_restore directory * Add no repository types callout for Cloud edge case * Redirect invalid section param to repositories * Add warning empty prompt if all repositories have errrors * Replace repository cards with EuiCard * Add snapshot doc link to repository error empty prompt * Remove auto-verification from list and get routes, add separate verification route, add manual verification to repository detail panel * Update copy and remove obsolete test * Remove unused scss files * Final changes to repository cards

cjcenizal added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Apr 9, 2019

cjcenizal requested a review from jen-huang April 9, 2019 23:59

cjcenizal added the non-issue Indicates to automation that a pull request should not appear in the release notes label Apr 10, 2019

cjcenizal commented Apr 10, 2019

View reviewed changes

cjcenizal added 2 commits April 10, 2019 16:11

Add SnapshotTable and SnapshotDetails.

a67b93c

cjcenizal force-pushed the sr/snapshot-table branch from bb9ee09 to c882a83 Compare April 10, 2019 23:12

Order snapshots from newest to oldest.

4a4d5c1

Add content to details panel. Add initialValue config option to useRe…

e5ba296

…quest.

cjcenizal commented Apr 11, 2019

View reviewed changes

cjcenizal added 2 commits April 10, 2019 19:13

Fix TS errors and API tests.

8c7c0b3

Add formatDate service to text module. Show time info in detail panel.

f6263c9

cjcenizal added 3 commits April 10, 2019 20:10

Fix TS errors.

564f59f

Fix regression introduced into repository requests by missing initial…

590684d

…Data.

Add loading and missing states to detail panel.

14c3faa

cjcenizal force-pushed the sr/snapshot-table branch from f7e6b8b to 14c3faa Compare April 11, 2019 03:33

Fix regression in repository routing.

549405c

Revert change to rollups.

cc1378e

Cleanup.

0a640ef

- Remove route param aliases. - Remove unnecessary <em> tags.

Fix bug introduced into useRequest by using a request-bound flag for …

dfb2a5b

…tracking outdated requests.

jen-huang approved these changes Apr 11, 2019

View reviewed changes

cjcenizal merged commit 7f621e8 into elastic:feature/snapshots Apr 12, 2019

cjcenizal deleted the sr/snapshot-table branch April 12, 2019 00:12

Conversation

cjcenizal commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Apr 9, 2019

Uh oh!

elasticmachine commented Apr 10, 2019

💚 Build Succeeded

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 10, 2019

💚 Build Succeeded

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Apr 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Apr 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Apr 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Apr 11, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Apr 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Apr 11, 2019

💚 Build Succeeded

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjcenizal commented Apr 11, 2019

Uh oh!

elasticmachine commented Apr 12, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

cjcenizal commented Apr 9, 2019 •

edited

Loading