Skip to content

Add aria-hidden={true} to decorative EuiIcon instances #268367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexwizp merged 4 commits into from
May 8, 2026
+5 −5
Merged

Add aria-hidden={true} to decorative EuiIcon instances #268367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aaaed37
Initial plan
Copilot May 8, 2026
f33c356
fix: add aria-hidden={true} to decorative EuiIcon instances
Copilot May 8, 2026
98c4c00
Merge branch 'main' into copilot/fix-eslint-icon-accessibility-violat…
alexwizp May 8, 2026
bd36280
Merge branch 'main' into copilot/fix-eslint-icon-accessibility-violat…
alexwizp May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/packages/shared/kbn-dom-drag-drop/src/drop_targets/swap_duplicate_combine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const getExtraTarget = ({
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexItem grow={false}>
<EuiIcon size="m" type={icon} />
<EuiIcon size="m" type={icon} aria-hidden={true} />
</EuiFlexItem>
<EuiFlexItem grow={false} data-test-subj={`${DEFAULT_DATA_TEST_SUBJ}-dropTarget-${type}`}>
<EuiText size="s">{label}</EuiText>
Expand Down
8 changes: 4 additions & 4 deletions src/platform/plugins/shared/data/public/search/session/sessions_mgmt/components/status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const getStatusAttributes = ({
});

return {
icon: <EuiIcon color="#9AA" type="clock" />,
icon: <EuiIcon color="#9AA" type="clock" aria-hidden={true} />,
label: <TableText>{getStatusText(session.status)}</TableText>,
toolTipContent,
};
Expand All @@ -108,7 +108,7 @@ const getStatusAttributes = ({

case SearchSessionStatus.CANCELLED:
return {
icon: <EuiIcon color="#9AA" type="error" />,
icon: <EuiIcon color="#9AA" type="error" aria-hidden={true} />,
label: <TableText>{getStatusText(session.status)}</TableText>,
toolTipContent: i18n.translate('data.mgmt.searchSessions.status.message.cancelled', {
defaultMessage: 'Cancelled by user',
Expand All @@ -118,7 +118,7 @@ const getStatusAttributes = ({
case SearchSessionStatus.ERROR:
return {
textColor: 'danger',
icon: <EuiIcon color="danger" type="error" />,
icon: <EuiIcon color="danger" type="error" aria-hidden={true} />,
label: <TableText>{getStatusText(session.status)}</TableText>,
toolTipContent:
session.errors && session.errors.length > 0
Expand All @@ -140,7 +140,7 @@ const getStatusAttributes = ({

return {
textColor: 'success',
icon: <EuiIcon color="success" type="checkCircleFill" />,
icon: <EuiIcon color="success" type="checkCircleFill" aria-hidden={true} />,
label: <TableText>{getStatusText(session.status)}</TableText>,
toolTipContent,
};
Expand Down
Loading