Skip to content

[ML] Update embeddable license check for capability check#267977

Merged
jgowdyelastic merged 2 commits into
elastic:mainfrom
jgowdyelastic:change-embeddable-licence-check-for-capability-check
May 7, 2026
Merged

[ML] Update embeddable license check for capability check#267977
jgowdyelastic merged 2 commits into
elastic:mainfrom
jgowdyelastic:change-embeddable-licence-check-for-capability-check

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented May 6, 2026

Supersedes #267902

The changes added in #267902 were unnecessary, rather than checking the licence, we should be checking capabilities, which are controlled by the licence along with other other factors.

This PR removes the previously added licence check functions and adds a new async capability check.
Named checkPermissionAsync to match the already existing checkPermission

@jgowdyelastic jgowdyelastic requested a review from rbrtj May 6, 2026 13:41
@jgowdyelastic jgowdyelastic self-assigned this May 6, 2026
@jgowdyelastic jgowdyelastic added :ml release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.5.0 labels May 6, 2026
@jgowdyelastic jgowdyelastic marked this pull request as ready for review May 6, 2026 13:41
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner May 6, 2026 13:41
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/ml-ui (:ml)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #120 / Serverless Common UI - Home Page Sample data in serverless "after all" hook for "Sample data loads"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.6MB 5.6MB -15.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 88.9KB 88.7KB -226.0B
Unknown metric groups

async chunk count

id before after diff
ml 114 116 +2

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit c9ef827 into elastic:main May 7, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants