Skip to content

[ML] License check refactor#267902

Merged
jgowdyelastic merged 1 commit into
elastic:mainfrom
jgowdyelastic:license-check-refactor
May 6, 2026
Merged

[ML] License check refactor#267902
jgowdyelastic merged 1 commit into
elastic:mainfrom
jgowdyelastic:license-check-refactor

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

Moves recently added licence checks to the ml_license.ts file and renames them.

@jgowdyelastic jgowdyelastic requested a review from rbrtj May 6, 2026 08:43
@jgowdyelastic jgowdyelastic self-assigned this May 6, 2026
@jgowdyelastic jgowdyelastic added :ml release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.5.0 labels May 6, 2026
@jgowdyelastic jgowdyelastic marked this pull request as ready for review May 6, 2026 08:43
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner May 6, 2026 08:43
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 4280 4278 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.6MB 5.6MB -795.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 88.6KB 88.9KB +318.0B

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 4c31d96 into elastic:main May 6, 2026
88 checks passed
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request May 6, 2026
Moves recently added licence checks to the `ml_license.ts` file and
renames them.
jgowdyelastic added a commit that referenced this pull request May 7, 2026
Supersedes #267902

The changes added in #267902 were
unnecessary, rather than checking the licence, we should be checking
capabilities, which are controlled by the licence along with other other
factors.

This PR removes the previously added licence check functions and adds a
new async capability check.
Named `checkPermissionAsync` to match the already existing
`checkPermission`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants